You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lu...@apache.org on 2013/04/22 16:29:57 UTC
svn commit: r1470543 -
/myfaces/core/branches/2.1.x/impl/src/main/java/org/apache/myfaces/view/facelets/compiler/UILeaf.java
Author: lu4242
Date: Mon Apr 22 14:29:56 2013
New Revision: 1470543
URL: http://svn.apache.org/r1470543
Log:
MYFACES-3712 [perf] UILeaf.setId() does not require the valid id check, because it is always generated by facelets
Modified:
myfaces/core/branches/2.1.x/impl/src/main/java/org/apache/myfaces/view/facelets/compiler/UILeaf.java
Modified: myfaces/core/branches/2.1.x/impl/src/main/java/org/apache/myfaces/view/facelets/compiler/UILeaf.java
URL: http://svn.apache.org/viewvc/myfaces/core/branches/2.1.x/impl/src/main/java/org/apache/myfaces/view/facelets/compiler/UILeaf.java?rev=1470543&r1=1470542&r2=1470543&view=diff
==============================================================================
--- myfaces/core/branches/2.1.x/impl/src/main/java/org/apache/myfaces/view/facelets/compiler/UILeaf.java (original)
+++ myfaces/core/branches/2.1.x/impl/src/main/java/org/apache/myfaces/view/facelets/compiler/UILeaf.java Mon Apr 22 14:29:56 2013
@@ -159,11 +159,14 @@ class UILeaf extends UIComponent impleme
@Override
public void setId(String id)
{
- isIdValid(id);
+ // UILeaf instance are just a wrapper for html markup. It never has
+ // an user defined id. The validation check here is just useless,
+ // because facelets algorithm ensures that.
+ //isIdValid(id);
_id = id;
_clientId = null;
}
-
+ /*
private void isIdValid(String string)
{
@@ -205,7 +208,7 @@ class UILeaf extends UIComponent impleme
+ c + "\"");
}
}
- }
+ }*/
private String getComponentLocation(UIComponent component)
{