You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Guenter Knauf <fu...@apache.org> on 2010/08/03 08:35:26 UTC
Re: [Patch] apr trunk doesn't install apu.h
Am 06.06.2010 21:13, schrieb Rainer Jung:
> Subject says it all, more in the patch log message at:
>
> http://people.apache.org/~rjung/patches/apr-trunk-fix-broken-installation-of-apu_h.patch
>
>
> On the long term apu.h might go completely, but until now it is still
> referenced in a lot of installed header files. So e.g. httpd trunk
> doesn't compile against an installed apr 2 because apr_hooks.h includes
> apu.h.
fine so far, but also bad since shouldnt we at least make sure that APR
itself builds without apu.h? There are still a bunch of headers which
want to include apu.h - is it ok that I change them all to apr.h, or do
I have to mimic this dummy apu.h creation?
Building C:/projects/svn-httpd/apr-head/build
Generating nw_export.i
### mwccnlm Compiler:
# File: nw_export.inc
# ----------------------
# 5: #include "apu.h"
# Error: ^
# the file 'apu.h' cannot be opened
### mwccnlm Compiler:
# In: ..\include\apr_base64.h
# --------------------------------
# 27: #include "apu.h"
# Error: ^
# the file 'apu.h' cannot be opened
### mwccnlm Compiler:
# In: ..\include\apr_buckets.h
# ---------------------------------
# 28: #include "apu.h"
# Error: ^
# the file 'apu.h' cannot be opened
### mwccnlm Compiler:
# In: ..\include\apr_date.h
# ------------------------------
# 35: #include "apu.h"
# Error: ^
# the file 'apu.h' cannot be opened
### mwccnlm Compiler:
# In: ..\include\apr_dbd.h
# -----------------------------
# 24: #include "apu.h"
# Error: ^
# the file 'apu.h' cannot be opened
### mwccnlm Compiler:
# In: ..\include\apr_dbm.h
# -----------------------------
# 20: #include "apu.h"
# Error: ^
# the file 'apu.h' cannot be opened
### mwccnlm Compiler:
# In: ..\include\apr_hooks.h
# -------------------------------
# 20: #include "apu.h"
# Error: ^
# the file 'apu.h' cannot be opened
### mwccnlm Compiler:
# In: ..\include\apr_ldap_url.h
# ----------------------------------
# 35: #include "apu.h"
# Error: ^
# the file 'apu.h' cannot be opened
### mwccnlm Compiler:
# In: ..\include\apr_md4.h
# -----------------------------
# 44: #include "apu.h"
# Error: ^
# the file 'apu.h' cannot be opened
### mwccnlm Compiler:
# In: ..\include\apr_xlate.h
# -------------------------------
# 20: #include "apu.h"
# Error: ^
# the file 'apu.h' cannot be opened
### mwccnlm Compiler:
# In: ..\include\apr_md5.h
# -----------------------------
# 50: #include "apu.h"
# Error: ^
# the file 'apu.h' cannot be opened
### mwccnlm Compiler:
# In: ..\include\apr_reslist.h
# ---------------------------------
# 26: #include "apu.h"
# Error: ^
# the file 'apu.h' cannot be opened
### mwccnlm Compiler:
# In: ..\include\apr_optional.h
# ----------------------------------
# 20: #include "apu.h"
# Error: ^
# the file 'apu.h' cannot be opened
### mwccnlm Compiler:
# In: ..\include\apr_queue.h
# -------------------------------
# 28: #include "apu.h"
# Error: ^
# the file 'apu.h' cannot be opened
### mwccnlm Compiler:
# In: ..\include\apr_rmm.h
# -----------------------------
# 32: #include "apu.h"
# Error: ^
# the file 'apu.h' cannot be opened
### mwccnlm Compiler:
# In: ..\include\apr_sdbm.h
# ------------------------------
# 27: #include "apu.h"
# Error: ^
# the file 'apu.h' cannot be opened
### mwccnlm Compiler:
# In: ..\include\apr_sha1.h
# ------------------------------
# 26: #include "apu.h"
# Error: ^
# the file 'apu.h' cannot be opened
### mwccnlm Compiler:
# In: ..\include\apr_strmatch.h
# ----------------------------------
# 24: #include "apu.h"
# Error: ^
# the file 'apu.h' cannot be opened
### mwccnlm Compiler:
# File: nw_export.inc
# ----------------------
# 62: #include "apr_support.h"
# Error: ^
# the file 'apr_support.h' cannot be opened
### mwccnlm Compiler:
# In: ..\include\apr_thread_pool.h
# -------------------------------------
# 22: #include "apu.h"
# Error: ^
# the file 'apu.h' cannot be opened
### mwccnlm Compiler:
# In: ..\include\apr_uri.h
# -----------------------------
# 29: #include "apu.h"
# Error: ^
# the file 'apu.h' cannot be opened
### mwccnlm Compiler:
# In: ..\include\apr_uuid.h
# ------------------------------
# 24: #include "apu.h"
# Error: ^
# the file 'apu.h' cannot be opened
### mwccnlm Compiler:
# In: ..\include\apr_xml.h
# -----------------------------
# 32: #include "apu.h"
# Error: ^
# the file 'apu.h' cannot be opened
### mwccnlm Compiler:
# In: ..\include\apu_want.h
# ------------------------------
# 17: #include "apu.h" /* configuration data */
# Error: ^
# the file 'apu.h' cannot be opened
Re: [Patch] apr trunk doesn't install apu.h
Posted by Rainer Jung <ra...@kippdata.de>.
Hi Günter,
On 03.08.2010 08:35, Guenter Knauf wrote:
> Am 06.06.2010 21:13, schrieb Rainer Jung:
>> Subject says it all, more in the patch log message at:
>>
>> http://people.apache.org/~rjung/patches/apr-trunk-fix-broken-installation-of-apu_h.patch
>>
>>
>>
>> On the long term apu.h might go completely, but until now it is still
>> referenced in a lot of installed header files. So e.g. httpd trunk
>> doesn't compile against an installed apr 2 because apr_hooks.h includes
>> apu.h.
> fine so far, but also bad since shouldnt we at least make sure that APR
> itself builds without apu.h? There are still a bunch of headers which
> want to include apu.h - is it ok that I change them all to apr.h, or do
> I have to mimic this dummy apu.h creation?
apr trunk contains apr-util, it has been merged into it and there is no
more apr-util trunk.
apu.h in apr trunk contains only one functional line:
#include <apr.h>
so it doesn't make sense any longer tou include apu.h nstead of apr.h
from inside apr.
I guess apu.h is only still there, to keep apr trunk a bit more
compatible with existing code using apr/apu (like httpd). E.g. httpd
trunk builds against apr trunk and also against apr/apu branches.
In short: I gues it is OK to only include apr.h from inside apr, but you
also have to install the redirecting apu.h in order to satisfy the needs
of the software using apr/apu.
Regards,
Rainer
Re: [Patch] apr trunk doesn't install apu.h
Posted by Guenter Knauf <fu...@apache.org>.
Am 03.08.2010 08:44, schrieb William A. Rowe Jr.:
> On 8/3/2010 1:35 AM, Guenter Knauf wrote:
>> fine so far, but also bad since shouldnt we at least make sure that APR
>> itself builds without apu.h? There are still a bunch of headers which
>> want to include apu.h - is it ok that I change them all to apr.h, or do
>> I have to mimic this dummy apu.h creation?
>
> Yes, and yes (for external users).
>
> apu.h should be nothing but a stub, and there is no reason to actually
> generate the dummy header, it should simply exist in include/ (and did
> the last time I looked?).
>
ah, ok - since we previously generated apu.h it was also cleaned away
with make ... :)
Now restored from svn and removed build rule, that looks better ...
Gün.
Re: [Patch] apr trunk doesn't install apu.h
Posted by "William A. Rowe Jr." <wr...@rowe-clan.net>.
On 8/3/2010 1:35 AM, Guenter Knauf wrote:
> fine so far, but also bad since shouldnt we at least make sure that APR
> itself builds without apu.h? There are still a bunch of headers which
> want to include apu.h - is it ok that I change them all to apr.h, or do
> I have to mimic this dummy apu.h creation?
Yes, and yes (for external users).
apu.h should be nothing but a stub, and there is no reason to actually
generate the dummy header, it should simply exist in include/ (and did
the last time I looked?).