[GitHub] [pinot] walterddr commented on a diff in pull request #10698: [multistage] separate leaf and intermediate threadpool

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #10698:
URL: https://github.com/apache/pinot/pull/10698#discussion_r1180524574


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java:
##########
@@ -128,11 +130,14 @@ public void init(PinotConfiguration config, InstanceDataManager instanceDataMana
     try {
       long releaseMs = config.getProperty(QueryConfig.KEY_OF_SCHEDULER_RELEASE_TIMEOUT_MS,
           QueryConfig.DEFAULT_SCHEDULER_RELEASE_TIMEOUT_MS);
-      _queryWorkerExecutorService = Executors.newFixedThreadPool(ResourceManager.DEFAULT_QUERY_WORKER_THREADS,
+      _queryWorkerIntermediateExecutorService = Executors.newFixedThreadPool(

Review Comment:
   We can limit the number of threads b/c when a opChain is waiting on mailbox it will back out from the worker pool and queue as unsubmitted opChain, when wake up by mailbox it will be re-added back to the worker pool 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org