You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/06/02 14:03:30 UTC

[GitHub] [nifi] Lehel44 commented on a change in pull request #5115: NIFI-8642 Select the default Old Gen Memory Pool for Memory Reporting…

Lehel44 commented on a change in pull request #5115:
URL: https://github.com/apache/nifi/pull/5115#discussion_r643995331



##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-reporting-tasks/src/main/java/org/apache/nifi/controller/MonitorMemory.java
##########
@@ -90,14 +91,20 @@
         + " that the memory pool is exceeding this threshold.")
 public class MonitorMemory extends AbstractReportingTask {
 
+    private static final List<String> GC_OLD_GEN_POOLS = Arrays.asList("Tenured Gen", "PS Old Gen", "G1 Old Gen", "CMS Old Gen", "ZHeap");

Review comment:
       What do you think of making this unmodifiable? Should it be modifiable?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org