You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2007/08/11 17:45:34 UTC

svn commit: r564931 - in /jakarta/jmeter/branches/rel-2-2: src/core/org/apache/jmeter/engine/StandardJMeterEngine.java xdocs/changes.xml

Author: sebb
Date: Sat Aug 11 08:45:33 2007
New Revision: 564931

URL: http://svn.apache.org/viewvc?view=rev&rev=564931
Log:
Bug 43007 - Test ends before all threadgroups started

Modified:
    jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/engine/StandardJMeterEngine.java
    jakarta/jmeter/branches/rel-2-2/xdocs/changes.xml

Modified: jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/engine/StandardJMeterEngine.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/engine/StandardJMeterEngine.java?view=diff&rev=564931&r1=564930&r2=564931
==============================================================================
--- jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/engine/StandardJMeterEngine.java (original)
+++ jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/engine/StandardJMeterEngine.java Sat Aug 11 08:45:33 2007
@@ -60,6 +60,8 @@
 
 	private transient Map allThreads;
 
+	private volatile boolean startingGroups; // flag to show that groups are still being created
+	
 	private boolean running = false;
 
 	private boolean serialized = false;
@@ -245,7 +247,7 @@
 		try {
             allThreads.remove(thread);
             log.info("Ending thread " + thread.getThreadName());
-            if (!serialized && allThreads.size() == 0 && !schcdule_run) {
+            if (!serialized && !schcdule_run && !startingGroups && allThreads.size() == 0 ) {
             	log.info("Stopping test");
             	stopTest();
             }
@@ -358,6 +360,7 @@
 		JMeterContextService.getContext().setSamplingStarted(true);
 		int groupCount = 0;
         JMeterContextService.clearTotalThreads();
+        startingGroups = true;
 		while (iter.hasNext()) {
 			groupCount++;
 			ThreadGroup group = (ThreadGroup) iter.next();
@@ -414,6 +417,7 @@
 				}
 			}
 		}
+        startingGroups = false;
 	}
 
 	/**

Modified: jakarta/jmeter/branches/rel-2-2/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jakarta/jmeter/branches/rel-2-2/xdocs/changes.xml?view=diff&rev=564931&r1=564930&r2=564931
==============================================================================
--- jakarta/jmeter/branches/rel-2-2/xdocs/changes.xml (original)
+++ jakarta/jmeter/branches/rel-2-2/xdocs/changes.xml Sat Aug 11 08:45:33 2007
@@ -38,6 +38,7 @@
 <li>Clarified HTTP Request Defaults usage of the port field</li>
 <li>Bug 43006 - NPE if icon.properties file not found</li>
 <li>Bug 42918 - Size Assertion now treats an empty response as having zero length</li>
+<li>Bug 43007 - Test ends before all threadgroups started</li>
 </ul>
 
 <h3>Version 2.3RC3</h3>



---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org