You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@unomi.apache.org by GitBox <gi...@apache.org> on 2020/04/01 08:12:21 UTC

[GitHub] [unomi] sergehuber commented on issue #142: Unomi 296

sergehuber commented on issue #142: Unomi 296
URL: https://github.com/apache/unomi/pull/142#issuecomment-607101582
 
 
   Hello,
   
   Thank you for your contribution, but I found a few issues with it. 
   
   1. Please do the PR against the GraphQL branch and not the master, this way this will avoid having the comparison between the branches
   2. Please add a minimal description to the PR, or at least update the ticket
   3. I would have preferred that we avoid integrating the Javascript directly but instead using the frontend-maven-plugin to setup the project and have the Javascript pull directly from NPM. You can find more information about this plugin here: https://github.com/eirslett/frontend-maven-plugin
   
   Best regards,
     Serge Huber.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services