You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/02/03 13:41:21 UTC

[GitHub] [camel-k] phantomjinx commented on a change in pull request #1978: Refactors the deploy directory to make config directory single source of CRD truth

phantomjinx commented on a change in pull request #1978:
URL: https://github.com/apache/camel-k/pull/1978#discussion_r569420588



##########
File path: script/gen_crd.sh
##########
@@ -20,49 +20,52 @@ set -e
 location=$(dirname $0)
 apidir=$location/../pkg/apis/camel
 
-echo "Generating CRDs..."
-
 cd $apidir
-$CONTROLLER_GEN crd paths=./... output:crd:artifacts:config=false output:crd:dir=../../../deploy/crds crd:crdVersions=v1
+$CONTROLLER_GEN crd paths=./... output:crd:artifacts:config=../../../config/crd/bases output:crd:dir=../../../config/crd/bases crd:crdVersions=v1
 
-# cleanup
-rm -r ./config
+# cleanup working diretory in $apidir

Review comment:
       👍🏼




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org