You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ah...@apache.org on 2019/01/02 23:52:17 UTC

[royale-asjs] 01/02: use ContainerDataBinding. ApplicationDataBinding is probably ok for Basic Application's lifecycle, but for emulation, the viewChange was firing before the elements in the view were created so binding was firing off too soon.

This is an automated email from the ASF dual-hosted git repository.

aharui pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git

commit 7fd5f0b460fb8a8f9ca0dfb5f64e9e5bd8eb6488
Author: Alex Harui <ah...@apache.org>
AuthorDate: Wed Jan 2 15:51:33 2019 -0800

    use ContainerDataBinding.  ApplicationDataBinding is probably ok for Basic Application's lifecycle, but for emulation, the viewChange was firing before the elements in the view were created so binding was firing off too soon.
---
 frameworks/projects/MXRoyale/src/main/royale/mx/core/Application.as   | 3 +--
 .../SparkRoyale/src/main/royale/spark/components/Application.as       | 4 ++--
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/frameworks/projects/MXRoyale/src/main/royale/mx/core/Application.as b/frameworks/projects/MXRoyale/src/main/royale/mx/core/Application.as
index 800f3a2..68f0de1 100644
--- a/frameworks/projects/MXRoyale/src/main/royale/mx/core/Application.as
+++ b/frameworks/projects/MXRoyale/src/main/royale/mx/core/Application.as
@@ -66,7 +66,6 @@ COMPILE::JS {
     import org.apache.royale.core.HTMLElementWrapper;
 }
 
-import org.apache.royale.binding.ApplicationDataBinding;
 import org.apache.royale.binding.ContainerDataBinding;
 import org.apache.royale.core.AllCSSValuesImpl;
 import org.apache.royale.core.IBead;
@@ -309,7 +308,7 @@ public class Application extends Container implements IStrand, IParent, IEventDi
         typeNames += " Application";
 		
 		this.valuesImpl = new AllCSSValuesImpl();
-		addBead(new ApplicationDataBinding());
+		addBead(new ContainerDataBinding()); // ApplicationDataBinding fires too soon
 		addBead(new ApplicationLayout());
 
         instanceParent = this;
diff --git a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/Application.as b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/Application.as
index 86d92a8..f52989c 100644
--- a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/Application.as
+++ b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/Application.as
@@ -70,7 +70,7 @@ COMPILE::JS {
     import org.apache.royale.core.HTMLElementWrapper;
 }
 
-import org.apache.royale.binding.ApplicationDataBinding;
+import org.apache.royale.binding.ContainerDataBinding;
 import org.apache.royale.core.AllCSSValuesImpl;
 import org.apache.royale.core.IFlexInfo;
 import org.apache.royale.core.IParent;
@@ -318,7 +318,7 @@ public class Application extends SkinnableContainer implements IStrand, IParent,
         initResizeBehavior(); */
         
         this.valuesImpl = new AllCSSValuesImpl();
-        addBead(new ApplicationDataBinding());
+        addBead(new ContainerDataBinding());
         
         COMPILE::JS
         {