[jira] [Work logged] (GOBBLIN-1717) Correct `IcebergDatasetTest` semantics

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-1717?focusedWorklogId=813417&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-813417 ]

ASF GitHub Bot logged work on GOBBLIN-1717:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Sep/22 16:57
            Start Date: 29/Sep/22 16:57
    Worklog Time Spent: 10m 
      Work Description: phet opened a new pull request, #3571:
URL: https://github.com/apache/gobblin/pull/3571

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1717 - "Correct `IcebergDatasetTest` semantics"
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if applicable):
   
   Correct semantics of `IcebergDatasetTest` and streamline both impl and test code, including:
   
   * a different `FileSystem` mock instance between the source and destination
   * a unique, stable value for each unique path's `FileSystem.makeQualified` result
   * all within a streamlined mock for `FileSystem`
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   included
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 813417)
    Remaining Estimate: 0h
            Time Spent: 10m

> Correct `IcebergDatasetTest` semantics
> --------------------------------------
>
>                 Key: GOBBLIN-1717
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1717
>             Project: Apache Gobblin
>          Issue Type: Task
>          Components: distcp-ng
>            Reporter: Kip Kohn
>            Assignee: Issac Buenrostro
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> we need:
> a *different* `FileSystem` mock instance between the source and destination
> a *unique, stable* value for each unique path's `FileSystem.makeQualified` result
> all within a streamlined mock for `FileSystem`



--
This message was sent by Atlassian Jira
(v8.20.10#820010)