You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org> on 2007/08/21 15:37:33 UTC

[jira] Resolved: (WICKET-756) FormComponent.getValue uses equals instead of == to compare NO_RAW_INPUT

     [ https://issues.apache.org/jira/browse/WICKET-756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Quenot resolved WICKET-756.
-----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3.0-beta4
         Assignee: Jean-Baptiste Quenot

Fixed, thanks for reporting!

> FormComponent.getValue uses equals instead of == to compare NO_RAW_INPUT
> ------------------------------------------------------------------------
>
>                 Key: WICKET-756
>                 URL: https://issues.apache.org/jira/browse/WICKET-756
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.2.6
>            Reporter: Willis Boyce
>            Assignee: Jean-Baptiste Quenot
>            Priority: Trivial
>             Fix For: 1.3.0-beta4
>
>
> It looks like the "no raw input" condition is identified by the rawInput member actually referencing the NO_RAW_INPUT constant, not having the same string as NO_RAW_INPUT ("[-NO-RAW-INPUT-]").  Twice the code uses == or != to compare rawInput to NO_RAW_INPUT.  But once it uses the equals method instead.  This is probably wrong;  it should use ==.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.