You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/10 02:10:14 UTC
[GitHub] [pulsar] Shoothzj opened a new pull request #7498: [Issue 7450][conf] add gc log print for broker
Shoothzj opened a new pull request #7498:
URL: https://github.com/apache/pulsar/pull/7498
Fixes #7450
### Motivation
Gc log is a useful tool to help our positioning our jvm runing situation. It can use to solve gc param is not reasonable, memory leak. I think if pulsar need this too.
### Modifications
I modified start script, add gc log param.
### Does this pull request potentially affect one of the following parts:
- Anything that affects deployment: (yes)
added jvm param.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #7498: [Issue 7450][conf] add gc log print for broker
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #7498:
URL: https://github.com/apache/pulsar/pull/7498#issuecomment-726429446
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7498: [Issue 7450][conf] add gc log print for broker
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7498:
URL: https://github.com/apache/pulsar/pull/7498#issuecomment-656969804
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7498: [Issue 7450][conf] add gc log print for broker
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7498:
URL: https://github.com/apache/pulsar/pull/7498#issuecomment-721624364
@Shoothzj Could you please take a look at the last comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #7498: [Issue 7450][conf] add gc log print for broker
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #7498:
URL: https://github.com/apache/pulsar/pull/7498#issuecomment-726169797
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj closed pull request #7498: [Issue 7450][conf] add gc log print for broker
Posted by GitBox <gi...@apache.org>.
Shoothzj closed pull request #7498:
URL: https://github.com/apache/pulsar/pull/7498
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7498: [Issue 7450][conf] add gc log print for broker
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7498:
URL: https://github.com/apache/pulsar/pull/7498#issuecomment-726103197
@Shoothzj Seems after apply your last commit, the GC log only can enable in JDK 8 and JDK 11 right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #7498: [Issue 7450][conf] add gc log print for broker
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #7498:
URL: https://github.com/apache/pulsar/pull/7498#issuecomment-726126832
> @Shoothzj Seems after apply your last commit, the GC log only can enable in JDK 8 and JDK 11 right?
Yes. It's two mostly use major release version of java. Can we ignore the version less than 8 ? Then I can make it works on jdk 8 and later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on pull request #7498: [Issue 7450][conf] add gc log print for broker
Posted by GitBox <gi...@apache.org>.
merlimat commented on pull request #7498:
URL: https://github.com/apache/pulsar/pull/7498#issuecomment-665454192
@Shoothzj At least `PrintGCDateStamps` is not working on Java 11
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #7498: [Issue 7450][conf] add gc log print for broker
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #7498:
URL: https://github.com/apache/pulsar/pull/7498#issuecomment-725057644
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on pull request #7498: [Issue 7450][conf] add gc log print for broker
Posted by GitBox <gi...@apache.org>.
merlimat commented on pull request #7498:
URL: https://github.com/apache/pulsar/pull/7498#issuecomment-657084842
Wouldn't the GC CLI options be adapted when JVM > 1.8?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #7498: [Issue 7450][conf] add gc log print for broker
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #7498:
URL: https://github.com/apache/pulsar/pull/7498
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #7498: [Issue 7450][conf] add gc log print for broker
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #7498:
URL: https://github.com/apache/pulsar/pull/7498#issuecomment-662212621
> Wouldn't the GC CLI options be adapted when JVM > 1.8?
What's your meaning ? You want to tune gc options when jvm > 1.8?
If you want to ask if gc log option can work in jvm11 or later ? It can work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #7498: [Issue 7450][conf] add gc log print for broker
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #7498:
URL: https://github.com/apache/pulsar/pull/7498#issuecomment-724770364
> @Shoothzj Could you please take a look at the last comment?
I make it compat on two major java release. java8 and java11.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org