[GitHub] [lucene-solr] morissm commented on a change in pull request #417: Fixes SOLR-12550: ConcurrentUpdateSolrClient doesn't respect timeouts for commits and optimize

[GitBox <gi...@apache.org>]

morissm commented on a change in pull request #417: Fixes SOLR-12550: ConcurrentUpdateSolrClient doesn't respect timeouts for commits and optimize
URL: https://github.com/apache/lucene-solr/pull/417#discussion_r380969820
 
 

 ##########
 File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateSolrClient.java
 ##########
 @@ -121,9 +121,11 @@ protected ConcurrentUpdateSolrClient(String solrServerUrl,
   
   protected ConcurrentUpdateSolrClient(Builder builder) {
     this.internalHttpClient = (builder.httpClient == null);
-    this.client = new HttpSolrClient.Builder(builder.baseSolrUrl)
-        .withHttpClient(builder.httpClient)
-        .build();
+    HttpSolrClient.Builder httpClientBuilder = new HttpSolrClient.Builder(builder.baseSolrUrl)
+        .withHttpClient(builder.httpClient);
+    httpClientBuilder.connectionTimeoutMillis = builder.connectionTimeoutMillis;
+    httpClientBuilder.socketTimeoutMillis = builder.socketTimeoutMillis;
 
 Review comment:
   Right. I've updated the pull request accordingly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org