[GitHub] [shardingsphere] terrymanu commented on a change in pull request #6607: Add: add test case for MySQLServerInfo setServerVersion(#6574)

[GitBox <gi...@apache.org>]

terrymanu commented on a change in pull request #6607:
URL: https://github.com/apache/shardingsphere/pull/6607#discussion_r464812818



##########
File path: shardingsphere-db-protocol/shardingsphere-db-protocol-mysql/src/test/java/org/apache/shardingsphere/db/protocol/mysql/constant/MySQLServerInfoTest.java
##########
@@ -0,0 +1,27 @@
+package org.apache.shardingsphere.db.protocol.mysql.constant;
+
+import org.junit.Test;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertThat;
+
+public class MySQLServerInfoTest {
+
+    private final String SPECIFIC_VERSION = "5.1.47";
+
+    private final String EXPECTED_VERSION = "5.1.47-ShardingSphere-Proxy 5.0.0-RC1";
+
+    private final String EXPECTED_NULL_VERSION = "null-ShardingSphere-Proxy 5.0.0-RC1";

Review comment:
       Please do not use static fields in it can be inline in the test cases




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org