[GitHub] [avro] martin-g commented on a change in pull request #1570: AVRO-3424: Add build.sh step to encapsulate all the steps needed during release

[GitBox <gi...@apache.org>]

martin-g commented on a change in pull request #1570:
URL: https://github.com/apache/avro/pull/1570#discussion_r815350805



##########
File path: lang/csharp/build.sh
##########
@@ -76,6 +76,35 @@ do
       cp -pr build/doc/* ${ROOT}/build/avro-doc-${VERSION}/api/csharp
       ;;
 
+    release)
+      # "dist" step must be executed before this step

Review comment:
       What do you think about the following:
   
    extract all the logic in `dist)` to a function, so it will look like:
   ```bash
   ...
   dist)
      dist()
   release)
     release()
   ...
   ```
   
   This way the first few lines of `release()` could check if there are artifacts created by `dist()` and call `dist()` if there are no such. Something like:
   ```bash
   function release() {
     if [ ! -f .../some/file ]; then
       dist()
     fi
   
     # release stuff
   }
   ```

##########
File path: lang/csharp/build.sh
##########
@@ -76,6 +76,35 @@ do
       cp -pr build/doc/* ${ROOT}/build/avro-doc-${VERSION}/api/csharp
       ;;
 
+    release)
+      # "dist" step must be executed before this step
+
+      # If not specified use default location
+      [ "$NUGET_SOURCE" ] || NUGET_SOURCE="https://api.nuget.org/v3/index.json"
+
+      # Set NUGET_KEY beofre executing script. E.g. `NUGET_KEY="YOUR_KEY" ./build.sh release`

Review comment:
       typo in `before`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org