You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2016/05/17 20:39:12 UTC

[GitHub] couchdb-fauxton pull request: Deleting cors domain moved to modal

Github user benkeen commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/676#discussion_r63599211
  
    --- Diff: app/addons/fauxton/components.react.jsx ---
    @@ -403,7 +405,7 @@ function (app, FauxtonAPI, React, ReactDOM, ZeroClipboard, ReactBootstrap) {
                 {content}
               </Modal.Body>
               <Modal.Footer>
    -            <button className="btn btn-success js-btn-success" onClick={this.props.onSubmit}>
    +            <button className={btnClasses} onClick={this.props.onSubmit}>
                   <i className="fonticon-ok-circled"></i> {this.props.successButtonLabel}
                 </button>
    --- End diff --
    
    Just FYI, I did try using the ConfirmButton component but ran into a circular reference problem where one file required the other. As discussed, way back when, I'm going to combine those two files + this problem will go away.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---