You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Andrey Zagrebin (Jira)" <ji...@apache.org> on 2020/08/14 09:20:00 UTC
[jira] [Comment Edited] (FLINK-13598) frocksdb doesn't have arm
release
[ https://issues.apache.org/jira/browse/FLINK-13598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177575#comment-17177575 ]
Andrey Zagrebin edited comment on FLINK-13598 at 8/14/20, 9:19 AM:
-------------------------------------------------------------------
[~rmetzger] [~wangxiyuan]
When we released the last frocksdb versions, we used [this guide|https://github.com/dataArtisans/frocksdb/blob/FRocksDB-5.17.2/RELEASE-FROCKSDB.md] which is derived from [the RocksDB java client release guide|https://github.com/dataArtisans/frocksdb/blob/FRocksDB-5.17.2/java/RELEASE.md]. As you can see we mostly run 'make rocksdbjavastaticrelease'. I am not familiar with `make check_some` and I never tried it (maybe it is part of `rocksdbjavastaticrelease`).
We can try the linux approach from the release guide for arm to build the arm .so lib and extend the release jar with it. Anyways, we have to test the arm build, at least with Flink CI. If some RocksDB tests do not pass (maybe we also need to check the native rocksdb release guide/tests?) and 5.17.2 does not officially support arm, I am not sure how we can fully guarantee that it works or we say it is an experimental feature.
was (Author: azagrebin):
[~rmetzger] [~wangxiyuan]
When we released the last frocksdb versions, we used [the this guide|https://github.com/dataArtisans/frocksdb/blob/FRocksDB-5.17.2/RELEASE-FROCKSDB.md] which is derived from [the RocksDB java client release guide|https://github.com/dataArtisans/frocksdb/blob/FRocksDB-5.17.2/java/RELEASE.md]. As you can see we mostly run 'make rocksdbjavastaticrelease'. I am not familiar with `make check_some` and I never tried it (maybe it is part of `rocksdbjavastaticrelease`).
We can try the linux approach from the release guide for arm to build the arm .so lib and extend the release jar with it. Anyways, we have to test the arm build, at least with Flink CI. If some RocksDB tests do not pass (maybe we also need to check the native rocksdb release guide/tests?) and 5.17.2 does not officially support arm, I am not sure how we can fully guarantee that it works or we say it is an experimental feature.
> frocksdb doesn't have arm release
> ----------------------------------
>
> Key: FLINK-13598
> URL: https://issues.apache.org/jira/browse/FLINK-13598
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / State Backends
> Affects Versions: 1.9.0, 2.0.0
> Reporter: wangxiyuan
> Priority: Major
>
> Flink now uses frocksdb which forks from rocksdb for module *flink-statebackend-rocksdb*. It doesn't contain arm release.
> Now rocksdb supports ARM from [v6.2.2|https://search.maven.org/artifact/org.rocksdb/rocksdbjni/6.2.2/jar]
> Can frocksdb release an ARM package as well?
> Or AFAK, Since there were some bugs for rocksdb in the past, so that Flink didn't use it directly. Have the bug been solved in rocksdb already? Can Flink re-use rocksdb again now?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)