You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by gs...@apache.org on 2016/05/12 11:30:07 UTC

svn commit: r1743491 - /qpid/trunk/qpid/python/qpid_tests/broker_0_10/message.py

Author: gsim
Date: Thu May 12 11:30:07 2016
New Revision: 1743491

URL: http://svn.apache.org/viewvc?rev=1743491&view=rev
Log:
QPID-7259: delay adding transfers to completed set until we have verified queue is empty

Modified:
    qpid/trunk/qpid/python/qpid_tests/broker_0_10/message.py

Modified: qpid/trunk/qpid/python/qpid_tests/broker_0_10/message.py
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/python/qpid_tests/broker_0_10/message.py?rev=1743491&r1=1743490&r2=1743491&view=diff
==============================================================================
--- qpid/trunk/qpid/python/qpid_tests/broker_0_10/message.py (original)
+++ qpid/trunk/qpid/python/qpid_tests/broker_0_10/message.py Thu May 12 11:30:07 2016
@@ -481,14 +481,17 @@ class MessageTests(TestBase010):
         session.message_flow(unit = session.credit_unit.byte, value = 0xFFFFFFFFL, destination = "c")
         #check that expected number were received
         q = session.incoming("c")
+        ids = []
         for i in range(1, 6):            
             msg = q.get(timeout = 1)
-            session.receiver._completed.add(msg.id)#TODO: this may be done automatically
+            ids.append(msg.id)
             self.assertDataEquals(session, msg, "Message %d" % i)
         self.assertEmpty(q)
 
         #acknowledge messages and check more are received
         #TODO: there may be a nicer way of doing this
+        for i in ids:
+           session.receiver._completed.add(i)
         session.channel.session_completed(session.receiver._completed)
 
         for i in range(6, 11):



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org