You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/11/18 05:17:25 UTC

[GitHub] [calcite] hsyuan commented on a change in pull request #1589: [CALCITE-3508] Strengthen outer Join to inner if it is under a Filter that discards null values

hsyuan commented on a change in pull request #1589: [CALCITE-3508] Strengthen outer Join to inner if it is under a Filter that discards null values
URL: https://github.com/apache/calcite/pull/1589#discussion_r347204296
 
 

 ##########
 File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml
 ##########
 @@ -5397,22 +5397,25 @@ where d.deptno > 7 and e.deptno > 9]]>
         <Resource name="planBefore">
             <![CDATA[
 LogicalProject(EXPR$0=[1])
-  LogicalFilter(condition=[>($16, 9)])
 
 Review comment:
   By changing outer join to inner join, we get the chance to swap the inner and outer relation, then we may be able to build hash table on smaller side, which is a big advantage.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services