[GitHub] [lucene-solr] dsmiley commented on pull request #1574: SOLR-14566: Add request-ID to all distrib-search requests

[GitBox <gi...@apache.org>]

dsmiley commented on pull request #1574:
URL: https://github.com/apache/lucene-solr/pull/1574#issuecomment-648847445


   I agree with Jason's characterization relating to multiple use-cases, but there is overlap, and it'd be nice to see shared code for overlapping concerns instead of completely separate.  For example, tracing sets `MDCLoggingContext.setTracerId` which populates the 't' in every log -- cool!  Yet adding some new request ID parameter would not populate this but it would populate a request parameter.  So if a query triggers additional log lines for whatever reason, those log lines wouldn't have the request ID visible.  Furthermore, this new request ID being added is only for distributed search; it's not comprehensive (not distributed indexing or administrative requests).  To me, that's a shame.  But I'm not going to block what you're doing... progress not perfection, I suppose.
   
   What I would love to see is a simple Tracer implementation that does no distributed tracing (no tracing server).  It would merely generate an ID and propagate it via HTTP headers.  Thanks to Dat's existing open tracing integration work, this ID would show up in logs and would get propagated.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org