[GitHub] [couchdb] noahshaw11 opened a new pull request, #4100: Smoosh improvements

[GitBox <gi...@apache.org>]

noahshaw11 opened a new pull request, #4100:
URL: https://github.com/apache/couchdb/pull/4100

   ## Overview
   
   There are three bugs that are fixed in this PR:
   
   1. When smoosh is checking for compaction files to restore active compaction jobs, it uses the wrong file path. Currently, it looks for `<ShardPath>.{compact, compact.data, compact.meta}` instead of the correct `<ShardPath>.couch.{compact, compact.data, compact.meta}`.
   2. Persistence and recovery of view compaction jobs was never intended. This PR adds a check to skip the process for view compaction jobs.
   3. There is a subtle race condition where smoosh attempts to open a deleted db when remonitoring the compaction job. This PR adds a check to not remonitor compaction jobs for deleted db files.
   
   Furthermore, a toggle to enable and disable smoosh persistence has been added.
   
   ## Testing recommendations
   
   ```
   make eunit apps=smoosh
   ```
   
   ## Related Issues or Pull Requests
   
   Add smoosh queue persistence: https://github.com/apache/couchdb/pull/3766
   
   ## Checklist
   
   - [ ] Code is written and works correctly
   - [x] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] noahshaw11 closed pull request #4100: Smoosh improvements

[GitBox <gi...@apache.org>]

noahshaw11 closed pull request #4100: Smoosh improvements
URL: https://github.com/apache/couchdb/pull/4100


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] noahshaw11 commented on pull request #4100: Smoosh improvements

[GitBox <gi...@apache.org>]

noahshaw11 commented on PR #4100:
URL: https://github.com/apache/couchdb/pull/4100#issuecomment-1185764808

   Closing this PR since these commits were split into separate PRs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org