[jira] [Commented] (CLOUDSTACK-9136) SSH keypairs are left and cannot be removed after removing account

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192746#comment-15192746 ] 

ASF GitHub Bot commented on CLOUDSTACK-9136:
--------------------------------------------

Github user alexandrelimassantana commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1212#discussion_r55956795
  
    --- Diff: server/src/com/cloud/server/ManagementServerImpl.java ---
    @@ -3567,7 +3567,17 @@ public boolean deleteSSHKeyPair(final DeleteSSHKeyPairCmd cmd) {
             final Long domainId = cmd.getDomainId();
             final Long projectId = cmd.getProjectId();
     
    -        final Account owner = _accountMgr.finalizeOwner(caller, accountName, domainId, projectId);
    +        Account owner = null;
    --- End diff --
    
    Hello @ustcweizhou 
    
    I think this piece of code could be extracted from the deleteSSHKeyPair method. It has gotten a little big from it's past form and further improvements could be done outside of the main "deleteSSHKeyPair" flow if needed.


> SSH keypairs are left and cannot be removed after removing account
> ------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9136
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9136
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Wei Zhou
>            Assignee: Wei Zhou
>
> When we remove an account who have some ssh keypairs created/registered, the keypairs are left in cloudstack, we can still list it in Account->SSH Keypair page, but cannot remove them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)