[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2034: HDDS-4953. [SCM HA Security] Make CertStore DB updates for StoreValidateCertificate go via Ratis

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #2034:
URL: https://github.com/apache/ozone/pull/2034#discussion_r594079027



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMCertStore.java
##########
@@ -56,20 +61,21 @@
 /**
  * A Certificate Store class that persists certificates issued by SCM CA.
  */
-public class SCMCertStore implements CertificateStore {
+public final class SCMCertStore implements CertificateStore {
   private static final Logger LOG =
       LoggerFactory.getLogger(SCMCertStore.class);
   private SCMMetadataStore scmMetadataStore;
   private final Lock lock;
   private AtomicLong crlSequenceId;
 
-  public SCMCertStore(SCMMetadataStore dbStore, long sequenceId) {
+  private SCMCertStore(SCMMetadataStore dbStore, long sequenceId) {
     this.scmMetadataStore = dbStore;
     lock = new ReentrantLock();
     crlSequenceId = new AtomicLong(sequenceId);
   }
 
   @Override
+  @Replicate

Review comment:
       Replicate class in hadoop-hdds-server-scm and CertificateStore in hdds-server-framework. 
   hadoop-hdds-server-scm depends on framework. So, taken a simple approach and placed annotation in SCMCertSttore. 
   So, to move @Replication to CertificateStore I need to move the Replicate Class to hdds-server-framework. Let me do it.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org