You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org> on 2017/11/28 18:13:31 UTC
[Impala-ASF-CR] Revert "IMPALA-5538: Use explicit catalog versions for deleted objects"
Dimitris Tsirogiannis has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8667
Change subject: Revert "IMPALA-5538: Use explicit catalog versions for deleted objects"
......................................................................
Revert "IMPALA-5538: Use explicit catalog versions for deleted objects"
This reverts commit dd340b8810ecd00ad2ffe79845ca137e941aefb7.
Conflicts:
be/src/service/impala-server.cc
Change-Id: I3a2cddee5d565384e9de0e61b3b7d0d9075e0dce
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M be/src/catalog/catalog-util.cc
M be/src/catalog/catalog-util.h
M be/src/catalog/catalog.cc
M be/src/catalog/catalog.h
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/admission-controller.h
M be/src/scheduling/scheduler-test-util.cc
M be/src/scheduling/scheduler.cc
M be/src/service/impala-server.cc
M be/src/statestore/statestore.cc
M be/src/statestore/statestore.h
M common/thrift/CatalogInternalService.thrift
M common/thrift/StatestoreService.thrift
M fe/src/main/java/org/apache/impala/catalog/CatalogDeltaLog.java
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
M tests/statestore/test_statestore.py
21 files changed, 441 insertions(+), 480 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/8667/1
--
To view, visit http://gerrit.cloudera.org:8080/8667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3a2cddee5d565384e9de0e61b3b7d0d9075e0dce
Gerrit-Change-Number: 8667
Gerrit-PatchSet: 1
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
[Impala-ASF-CR] Revert "IMPALA-5538: Use explicit catalog versions for deleted objects"
Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8667 )
Change subject: Revert "IMPALA-5538: Use explicit catalog versions for deleted objects"
......................................................................
Patch Set 3: Code-Review+2
Rebase. Keep +2 from Alex.
--
To view, visit http://gerrit.cloudera.org:8080/8667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a2cddee5d565384e9de0e61b3b7d0d9075e0dce
Gerrit-Change-Number: 8667
Gerrit-PatchSet: 3
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Nov 2017 22:45:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-5538: Use explicit catalog versions for deleted objects"
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8667 )
Change subject: Revert "IMPALA-5538: Use explicit catalog versions for deleted objects"
......................................................................
Patch Set 1:
(1 comment)
I don't see the conflict in impala-server.cc. Could you add a quick comment in that file to point it out?
http://gerrit.cloudera.org:8080/#/c/8667/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/8667/1//COMMIT_MSG@7
PS1, Line 7: Revert "IMPALA-5538: Use explicit catalog versions for deleted objects"
please add a reference to the jira that motivates the revert.
--
To view, visit http://gerrit.cloudera.org:8080/8667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a2cddee5d565384e9de0e61b3b7d0d9075e0dce
Gerrit-Change-Number: 8667
Gerrit-PatchSet: 1
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Nov 2017 19:25:28 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Revert "IMPALA-5538: Use explicit catalog versions for deleted objects"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8667 )
Change subject: Revert "IMPALA-5538: Use explicit catalog versions for deleted objects"
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1536/
--
To view, visit http://gerrit.cloudera.org:8080/8667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a2cddee5d565384e9de0e61b3b7d0d9075e0dce
Gerrit-Change-Number: 8667
Gerrit-PatchSet: 3
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Tue, 28 Nov 2017 22:45:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-5538: Use explicit catalog versions for deleted objects"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8667 )
Change subject: Revert "IMPALA-5538: Use explicit catalog versions for deleted objects"
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a2cddee5d565384e9de0e61b3b7d0d9075e0dce
Gerrit-Change-Number: 8667
Gerrit-PatchSet: 3
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Wed, 29 Nov 2017 02:19:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-5538: Use explicit catalog versions for deleted objects"
Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8667
to look at the new patch set (#2).
Change subject: Revert "IMPALA-5538: Use explicit catalog versions for deleted objects"
......................................................................
Revert "IMPALA-5538: Use explicit catalog versions for deleted objects"
This reverts commit dd340b8810ecd00ad2ffe79845ca137e941aefb7.
This commit caused a number of issues tracked in IMPALA-6001. The
issues were due to the lack of atomicity between the catalog version
change and the addition to the delete log of a catalog object.
Conflicts:
be/src/service/impala-server.cc
Change-Id: I3a2cddee5d565384e9de0e61b3b7d0d9075e0dce
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M be/src/catalog/catalog-util.cc
M be/src/catalog/catalog-util.h
M be/src/catalog/catalog.cc
M be/src/catalog/catalog.h
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/admission-controller.h
M be/src/scheduling/scheduler-test-util.cc
M be/src/scheduling/scheduler.cc
M be/src/service/impala-server.cc
M be/src/statestore/statestore.cc
M be/src/statestore/statestore.h
M common/thrift/CatalogInternalService.thrift
M common/thrift/StatestoreService.thrift
M fe/src/main/java/org/apache/impala/catalog/CatalogDeltaLog.java
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
M tests/statestore/test_statestore.py
21 files changed, 441 insertions(+), 480 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/8667/2
--
To view, visit http://gerrit.cloudera.org:8080/8667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3a2cddee5d565384e9de0e61b3b7d0d9075e0dce
Gerrit-Change-Number: 8667
Gerrit-PatchSet: 2
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
[Impala-ASF-CR] Revert "IMPALA-5538: Use explicit catalog versions for deleted objects"
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8667 )
Change subject: Revert "IMPALA-5538: Use explicit catalog versions for deleted objects"
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/8667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a2cddee5d565384e9de0e61b3b7d0d9075e0dce
Gerrit-Change-Number: 8667
Gerrit-PatchSet: 2
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Nov 2017 19:40:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-5538: Use explicit catalog versions for deleted objects"
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8667 )
Change subject: Revert "IMPALA-5538: Use explicit catalog versions for deleted objects"
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a2cddee5d565384e9de0e61b3b7d0d9075e0dce
Gerrit-Change-Number: 8667
Gerrit-PatchSet: 2
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Nov 2017 22:40:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-5538: Use explicit catalog versions for deleted objects"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8667 )
Change subject: Revert "IMPALA-5538: Use explicit catalog versions for deleted objects"
......................................................................
Revert "IMPALA-5538: Use explicit catalog versions for deleted objects"
This reverts commit dd340b8810ecd00ad2ffe79845ca137e941aefb7.
This commit caused a number of issues tracked in IMPALA-6001. The
issues were due to the lack of atomicity between the catalog version
change and the addition to the delete log of a catalog object.
Conflicts:
be/src/service/impala-server.cc
Change-Id: I3a2cddee5d565384e9de0e61b3b7d0d9075e0dce
Reviewed-on: http://gerrit.cloudera.org:8080/8667
Reviewed-by: Dimitris Tsirogiannis <dt...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M be/src/catalog/catalog-util.cc
M be/src/catalog/catalog-util.h
M be/src/catalog/catalog.cc
M be/src/catalog/catalog.h
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/admission-controller.h
M be/src/scheduling/scheduler-test-util.cc
M be/src/scheduling/scheduler.cc
M be/src/service/impala-server.cc
M be/src/statestore/statestore.cc
M be/src/statestore/statestore.h
M common/thrift/CatalogInternalService.thrift
M common/thrift/StatestoreService.thrift
M fe/src/main/java/org/apache/impala/catalog/CatalogDeltaLog.java
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
M tests/statestore/test_statestore.py
21 files changed, 441 insertions(+), 480 deletions(-)
Approvals:
Dimitris Tsirogiannis: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a2cddee5d565384e9de0e61b3b7d0d9075e0dce
Gerrit-Change-Number: 8667
Gerrit-PatchSet: 4
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] Revert "IMPALA-5538: Use explicit catalog versions for deleted objects"
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8667 )
Change subject: Revert "IMPALA-5538: Use explicit catalog versions for deleted objects"
......................................................................
Patch Set 1:
> (1 comment)
>
> I don't see the conflict in impala-server.cc. Could you add a quick
> comment in that file to point it out?
It was because this line was changed in the meantime:
VLOG(3) << (item.deleted ? "Deleted " : "Added ") << "item: " << item.key
--
To view, visit http://gerrit.cloudera.org:8080/8667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a2cddee5d565384e9de0e61b3b7d0d9075e0dce
Gerrit-Change-Number: 8667
Gerrit-PatchSet: 1
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Nov 2017 19:40:28 +0000
Gerrit-HasComments: No