You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/21 07:58:18 UTC
[GitHub] [flink] liyafan82 commented on a change in pull request #8278:
[FLINK-12335][Table-runtime]Improvement the performance of class SegmentsUtil
liyafan82 commented on a change in pull request #8278: [FLINK-12335][Table-runtime]Improvement the performance of class SegmentsUtil
URL: https://github.com/apache/flink/pull/8278#discussion_r285895451
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/util/SegmentsUtil.java
##########
@@ -445,7 +443,7 @@ public static void bitSet(MemorySegment segment, int baseOffset, int index) {
* @param index bit index from base offset.
*/
public static boolean bitGet(MemorySegment segment, int baseOffset, int index) {
- int offset = baseOffset + ((index & BIT_BYTE_POSITION_MASK) >>> 3);
+ int offset = baseOffset + (index >>> 3);
Review comment:
Good suggestion. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services