You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "btlqql (via GitHub)" <gi...@apache.org> on 2026/09/07 02:14:37 UTC
[I] Add regression coverage for ACL diagnostics for enabled clusters without accounts [rocketmq-dashboard]
btlqql opened a new issue, #4042:
URL: https://github.com/apache/rocketmq-dashboard/issues/4042
## Problem
The current test suite does not cover ACL diagnostics for enabled clusters without accounts.
## Expected behavior
- A focused Vitest case locks the existing behavior.
- The targeted test file passes and fails if the covered behavior regresses.
## Scope
Only add regression coverage for $(@{Slug=acl-no-accounts; Focus=ACL diagnostics for enabled clusters without accounts; PrTitle=test(acl): cover enabled ACL with no plain access accounts; TestFile=web/src/utils/aclRiskDiagnostics.test.ts; Mode=existing; Append=describe('ACL risk diagnostics missing accounts', () => {
it('flags an enabled ACL with no plain access accounts as critical', () => {
const diagnostics = analyzeAclRisk(config({ accounts: [], accountCount: 0 }));
expect(diagnostics.summary.accountCount).toBe(0);
expect(diagnostics.issues.map((issue) => issue.code)).toContain('NO_PLAIN_ACCESS_ACCOUNTS');
});
});}.TestFile). No runtime behavior changes.
## Acceptance criteria
- [ ] The targeted Vitest file passes.
- [ ] git diff --check is clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add regression coverage for ACL diagnostics for enabled clusters without accounts [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4042:
URL: https://github.com/apache/rocketmq-dashboard/issues/4042#issuecomment-6115555355
This issue has been automatically closed because there has been no activity for 7 days. If you believe this issue is still relevant, please reopen it with updated information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add regression coverage for ACL diagnostics for enabled clusters without accounts [rocketmq-dashboard]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #4042:
URL: https://github.com/apache/rocketmq-dashboard/issues/4042#issuecomment-5564471779
**Issue Evaluation**
Category: `enhancement` | Status: **Evaluated**
**Feasibility:** feasible
**Scope:** Test suite — frontend regression coverage
**Compatibility:** No breaking changes
This is a well-scoped test coverage improvement request. Adding focused Vitest regression cases for the specified behavior will help prevent future regressions and improve overall code quality.
**Assessment:** The issue clearly defines the expected behavior and target test file. This is a good candidate for community contribution.
---
*Automated evaluation by github-manager-bot*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add regression coverage for ACL diagnostics for enabled clusters without accounts [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #4042: Add regression coverage for ACL diagnostics for enabled clusters without accounts
URL: https://github.com/apache/rocketmq-dashboard/issues/4042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org