[jira] [Commented] (KNOX-422) Build break with JVM IBM JAVA

["Larry McCay (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KNOX-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154719#comment-14154719 ] 

Larry McCay commented on KNOX-422:
----------------------------------

Hi [~poliva] - I am pleasantly surprised to see that the reflection actually incorporates IBM classes when they exist instead of sun classes - so that the functionality is equal - that is great.

I have reviewed it, built it and run unit tests and am about to manually test it functionally.

A couple nit-picks about the patch:

* the commented out import of sun classes should be removed
* use of whitespace should be aligned with the rest of the class - 2 spaces for indents
* I'm thinking that the reflection may be overwhelming the rest of the class and should probably be broken out to a separate class that is used by BaseKeystoreService - this will retain the readability of the class.

I thank you very much for this work and look forward to being able to run on the IBM JRE just as well as Oracle and OpenJDK!

> Build break with JVM IBM JAVA
> -----------------------------
>
>                 Key: KNOX-422
>                 URL: https://issues.apache.org/jira/browse/KNOX-422
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 0.4.0
>         Environment: RHEL 7 - power pc 64 - maven 3.2.1 - Java home: /home/jdk/ibm/ibm-java-ppc64-71/jre
>            Reporter: pascal oliva
>             Fix For: 0.5.0
>
>         Attachments: KNOX-422-1.patch, KNOX-422-2.patch
>
>
> The build failed with JVM IBM JAVA : Java version: 1.7.0, vendor: IBM Corporation
> [INFO] 30 errors
> [INFO] -------------------------------------------------------------
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] gateway ........................................... SUCCESS [  0.510 s]
> [INFO] gateway-test-utils ................................ SUCCESS [  1.631 s]
> [INFO] gateway-i18n ...................................... SUCCESS [  0.290 s]
> [INFO] gateway-util-common ............................... SUCCESS [  0.566 s]
> [INFO] gateway-util-launcher ............................. SUCCESS [  0.190 s]
> [INFO] gateway-util-urltemplate .......................... SUCCESS [  0.345 s]
> [INFO] gateway-test-ldap ................................. SUCCESS [  0.349 s]
> [INFO] gateway-test-ldap-launcher ........................ SUCCESS [  0.030 s]
> [INFO] gateway-i18n-logging-log4j ........................ SUCCESS [  0.064 s]
> [INFO] gateway-i18n-logging-sl4j ......................... SUCCESS [  0.060 s]
> [INFO] gateway-spi ....................................... FAILURE [  0.701 s]
> ...
> [ERROR] COMPILATION ERROR :
> [INFO] -------------------------------------------------------------
> [ERROR] /home/pascal/release/ibmsoe/knox/gateway-spi/src/main/java/org/apache/hadoop/gateway/services/security/impl/BaseKeystoreService.java:[88,9] cannot find symbol
>   symbol:   class X509CertInfo
> ...
> On /home/pascal/release/ibmsoe/knox/gateway-spi/src/main/java/org/apache/hadoop/gateway/services/security/impl/BaseKeystoreService.java
> import sun.security.x509.*; is not available with the JVM IBM JAVA



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)