You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/04/20 04:11:48 UTC

[GitHub] [incubator-hudi] xushiyan commented on issue #1530: [HUDI-809] Migrate CommonTestHarness to JUnit 5

xushiyan commented on issue #1530:
URL: https://github.com/apache/incubator-hudi/pull/1530#issuecomment-616297099


   @yanghua Thank you for taking care of the review. To better coordinate, just want to clarify the steps I'm taking for migrating the APIs:
   
   1. (This PR) Introduce `org.apache.hudi.common.testutils.HoodieCommonTestHarness` to allow incrementally migrate its subclasses, and complete migrations for `hudi-hadoop-mr`
   2. Migrate all subclasses of `HoodieClientTestHarness` (this completes `hudi-cli`)
   3. Migrate the remaining `HoodieCommonTestHarness` subclasses (this will merge `org.apache.hudi.common.HoodieCommonTestHarness` to the interim one in 1) )
   4. Migrate the remaining tests in `hudi-client`, `hudi-utilities`, and `hudi-common` 
   
   I'll try to keep the PR diff less than 500 +/- to make the review less daunting..but in case of 2) where all subclasses need to go at once, the diff may go up for that PR... just as a heads-up. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org