[GitHub] [orc] pavibhai commented on a change in pull request #668: ORC-742: Added Lazy IO for non filter columns

[GitBox <gi...@apache.org>]

pavibhai commented on a change in pull request #668:
URL: https://github.com/apache/orc/pull/668#discussion_r610750833



##########
File path: java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java
##########
@@ -230,15 +247,22 @@ protected RecordReaderImpl(ReaderImpl fileReader,
     SortedSet<Integer> filterColIds = new TreeSet<>();
     if (options.getPreFilterColumnNames() != null) {
       for (String colName : options.getPreFilterColumnNames()) {
-        int expandColId = findColumns(evolution, colName);
+        TypeDescription expandCol = findColumnType(evolution, colName);
         // If the column is not present in the file then this can be ignored from read.
-        if (expandColId != -1) {
-          filterColIds.add(expandColId);
+        while(expandCol != null && expandCol.getId() != -1) {

Review comment:
       will add




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org