You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2019/01/03 15:00:44 UTC
Review Request 69662: Displayed resource provider information in the
Mesos webui.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69662/
-----------------------------------------------------------
Review request for mesos, Armand Grillet, Benjamin Mahler, and Chun-Hung Hsiao.
Bugs: MESOS-8380
https://issues.apache.org/jira/browse/MESOS-8380
Repository: mesos
Description
-------
Displayed resource provider information in the Mesos webui.
Diffs
-----
src/webui/app/agents/agent.html a101a93dcdb95f257fe0ee967c92d2cdc1c84f84
src/webui/app/controllers.js 8049cf611895edea7c54b3c58d71e00d823a1fd3
Diff: https://reviews.apache.org/r/69662/diff/1/
Testing
-------
`make check`
Ran a local test with a `./src/test-csi-plugin`.
Thanks,
Benjamin Bannier
Re: Review Request 69662: Displayed resource provider information in
the Mesos webui.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69662/#review211658
-----------------------------------------------------------
Can you attach a screenshot of the web UI here?
- Chun-Hung Hsiao
On Jan. 3, 2019, 3 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69662/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2019, 3 p.m.)
>
>
> Review request for mesos, Armand Grillet, Benjamin Mahler, and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-8380
> https://issues.apache.org/jira/browse/MESOS-8380
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Displayed resource provider information in the Mesos webui.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html a101a93dcdb95f257fe0ee967c92d2cdc1c84f84
> src/webui/app/controllers.js 8049cf611895edea7c54b3c58d71e00d823a1fd3
>
>
> Diff: https://reviews.apache.org/r/69662/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
> Ran a local test with a `./src/test-csi-plugin`.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69662: Displayed resource provider information in
the Mesos webui.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Jan. 7, 2019, 10:52 p.m., Benjamin Mahler wrote:
> > Hm.. it looks like the rows are bigger in this table? (I measured in the screenshot and it appears to be the case). is it missing some attributes that the reservation table has?
Very good catch, thanks! There was a typo in one of the table attributes (`table-triped` instead of `table-striped`). For some reason this lead to bootstrap not applying the properties for `table-condensed` (i.e., `padding: 8px` instead of `padding: 5px`). This should be fixed now, screenshot is updated. Note that this table is modelled after the agents table in `agents.html`, but it should still look similar to the resources table below.
To debug this without even starting a resource provider (`test-csi-plugin` is not supported on macos), I hardcoded the RP information during development and confirmed with a real RP,
```
diff --git a/src/webui/app/controllers.js b/src/webui/app/controllers.js
index 08c9f1c0b..57491c6bd 100644
--- a/src/webui/app/controllers.js
+++ b/src/webui/app/controllers.js
@@ -694,7 +694,97 @@
$scope.agent = {};
$scope.agent.frameworks = {};
$scope.agent.completed_frameworks = {};
- $scope.agent.resource_providers = $scope.state.resource_providers;
+ $scope.agent.resource_providers = [{
+ "resource_provider_info": {
+ "id": {
+ "value": "bea4ab63-5a61-45ad-a00b-1a3345f46ca2"
+ },
+ "type": "org.apache.mesos.rp.local.storage",
+ "name": "test_slrp",
+ "default_reservations": [
+ {
+ "type": "DYNAMIC",
+ "role": "test-role"
+ }
+ ],
+ "storage": {
+ "plugin": {
+ "type": "org.apache.mesos.csi.test",
+ "name": "test_plugin",
+ "containers": [
+ {
+ "services": [
+ "CONTROLLER_SERVICE",
+ "NODE_SERVICE"
+ ],
+ "command": {
+ "uris": [
+ {
+ "value": "/home/bbannier/src/mesos/_/src/test-csi-plugin",
+ "executable": true,
+ "extract": true
+ }
+ ],
+ "shell": true,
+ "value": "./test-csi-plugin --available_capacity=2GB --work_dir=workdir --volumes='volume1:1GB;volume2:2GB'"
+ },
+ "resources": [
+ {
+ "name": "cpus",
+ "type": "SCALAR",
+ "scalar": {
+ "value": 0.1
+ }
+ },
+ {
+ "name": "mem",
+ "type": "SCALAR",
+ "scalar": {
+ "value": 200
+ }
+ }
+ ]
+ }
+ ]
+ }
+ }
+ },
+ "total_resources": [
+ {
+ "provider_id": {
+ "value": "bea4ab63-5a61-45ad-a00b-1a3345f46ca2"
+ },
+ "name": "disk",
+ "type": "SCALAR",
+ "scalar": {
+ "value": 1024
+ },
+ "reservations": [
+ {
+ "type": "DYNAMIC",
+ "role": "test-role"
+ }
+ ],
+ "disk": {
+ "source": {
+ "type": "RAW",
+ "vendor": "org.apache.mesos.csi.test.test_plugin",
+ "id": "volume1",
+ "metadata": {
+ "labels": [
+ {
+ "key": "path",
+ "value": "workdir/1GB-volume1"
+ }
+ ]
+ }
+ }
+ }
+ }
+ ]
+ }
+ ];
+
$scope.agent.url_prefix = agentURLPrefix(agent, false);
// The agent attaches a "/slave/log" file when either
```
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69662/#review211741
-----------------------------------------------------------
On Jan. 7, 2019, 11:33 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69662/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2019, 11:33 p.m.)
>
>
> Review request for mesos, Armand Grillet, Benjamin Mahler, and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-8380
> https://issues.apache.org/jira/browse/MESOS-8380
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Displayed resource provider information in the Mesos webui.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html a101a93dcdb95f257fe0ee967c92d2cdc1c84f84
> src/webui/app/controllers.js 8049cf611895edea7c54b3c58d71e00d823a1fd3
>
>
> Diff: https://reviews.apache.org/r/69662/diff/4/
>
>
> Testing
> -------
>
> `make check`
>
> Ran a local test with a `./src/test-csi-plugin`.
>
>
> File Attachments
> ----------------
>
> Screenshot Agent screen
> https://reviews.apache.org/media/uploaded/files/2019/01/04/ed920e7b-4072-49be-8801-3b875d529fad__Screen_Shot_2019-01-04_at_11.11.51_AM.png
> Screenshot Agent screen
> https://reviews.apache.org/media/uploaded/files/2019/01/07/8f494c0f-1c76-4734-9aae-7fb899589120__Screen_Shot_2019-01-07_at_9.42.51_PM.png
> Screenshot Agent screen
> https://reviews.apache.org/media/uploaded/files/2019/01/07/8a850bcd-dd30-4d25-bb37-60cd872ddd62__Screen_Shot_2019-01-07_at_11.27.49_PM.png
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69662: Displayed resource provider information in
the Mesos webui.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69662/#review211741
-----------------------------------------------------------
Hm.. it looks like the rows are bigger in this table? (I measured in the screenshot and it appears to be the case). is it missing some attributes that the reservation table has?
- Benjamin Mahler
On Jan. 7, 2019, 9:02 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69662/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2019, 9:02 p.m.)
>
>
> Review request for mesos, Armand Grillet, Benjamin Mahler, and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-8380
> https://issues.apache.org/jira/browse/MESOS-8380
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Displayed resource provider information in the Mesos webui.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html a101a93dcdb95f257fe0ee967c92d2cdc1c84f84
> src/webui/app/controllers.js 8049cf611895edea7c54b3c58d71e00d823a1fd3
>
>
> Diff: https://reviews.apache.org/r/69662/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
> Ran a local test with a `./src/test-csi-plugin`.
>
>
> File Attachments
> ----------------
>
> Screenshot Agent screen
> https://reviews.apache.org/media/uploaded/files/2019/01/04/ed920e7b-4072-49be-8801-3b875d529fad__Screen_Shot_2019-01-04_at_11.11.51_AM.png
> Screenshot Agent screen
> https://reviews.apache.org/media/uploaded/files/2019/01/07/8f494c0f-1c76-4734-9aae-7fb899589120__Screen_Shot_2019-01-07_at_9.42.51_PM.png
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69662: Displayed resource provider information in
the Mesos webui.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Jan. 9, 2019, 11:19 p.m., Chun-Hung Hsiao wrote:
> > src/webui/app/controllers.js
> > Lines 697 (patched)
> > <https://reviews.apache.org/r/69662/diff/4/?file=2118370#file2118370line697>
> >
> > Instead of setting `agent.resource_providers` with `state.resource_providers` and mutating each item, how about initializing it to `{}` and constructing each item one by one, like what we do for `agent.frameworks`, for consistency?
Done. I didn't go for an extra function since IMO there is little gain ATM.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69662/#review211802
-----------------------------------------------------------
On Jan. 10, 2019, 10:19 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69662/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2019, 10:19 a.m.)
>
>
> Review request for mesos, Armand Grillet, Benjamin Mahler, and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-8380
> https://issues.apache.org/jira/browse/MESOS-8380
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Displayed resource provider information in the Mesos webui.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html a101a93dcdb95f257fe0ee967c92d2cdc1c84f84
> src/webui/app/controllers.js 8049cf611895edea7c54b3c58d71e00d823a1fd3
>
>
> Diff: https://reviews.apache.org/r/69662/diff/5/
>
>
> Testing
> -------
>
> `make check`
>
> Ran a local test with a `./src/test-csi-plugin`.
>
>
> File Attachments
> ----------------
>
> Screenshot Agent screen
> https://reviews.apache.org/media/uploaded/files/2019/01/04/ed920e7b-4072-49be-8801-3b875d529fad__Screen_Shot_2019-01-04_at_11.11.51_AM.png
> Screenshot Agent screen
> https://reviews.apache.org/media/uploaded/files/2019/01/07/8f494c0f-1c76-4734-9aae-7fb899589120__Screen_Shot_2019-01-07_at_9.42.51_PM.png
> Screenshot Agent screen
> https://reviews.apache.org/media/uploaded/files/2019/01/07/8a850bcd-dd30-4d25-bb37-60cd872ddd62__Screen_Shot_2019-01-07_at_11.27.49_PM.png
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69662: Displayed resource provider information in
the Mesos webui.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69662/#review211802
-----------------------------------------------------------
Fix it, then Ship it!
It looks like a great start. Thanks for adding the UI!
src/webui/app/controllers.js
Lines 697 (patched)
<https://reviews.apache.org/r/69662/#comment297396>
Instead of setting `agent.resource_providers` with `state.resource_providers` and mutating each item, how about initializing it to `{}` and constructing each item one by one, like what we do for `agent.frameworks`, for consistency?
- Chun-Hung Hsiao
On Jan. 7, 2019, 10:33 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69662/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2019, 10:33 p.m.)
>
>
> Review request for mesos, Armand Grillet, Benjamin Mahler, and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-8380
> https://issues.apache.org/jira/browse/MESOS-8380
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Displayed resource provider information in the Mesos webui.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html a101a93dcdb95f257fe0ee967c92d2cdc1c84f84
> src/webui/app/controllers.js 8049cf611895edea7c54b3c58d71e00d823a1fd3
>
>
> Diff: https://reviews.apache.org/r/69662/diff/4/
>
>
> Testing
> -------
>
> `make check`
>
> Ran a local test with a `./src/test-csi-plugin`.
>
>
> File Attachments
> ----------------
>
> Screenshot Agent screen
> https://reviews.apache.org/media/uploaded/files/2019/01/04/ed920e7b-4072-49be-8801-3b875d529fad__Screen_Shot_2019-01-04_at_11.11.51_AM.png
> Screenshot Agent screen
> https://reviews.apache.org/media/uploaded/files/2019/01/07/8f494c0f-1c76-4734-9aae-7fb899589120__Screen_Shot_2019-01-07_at_9.42.51_PM.png
> Screenshot Agent screen
> https://reviews.apache.org/media/uploaded/files/2019/01/07/8a850bcd-dd30-4d25-bb37-60cd872ddd62__Screen_Shot_2019-01-07_at_11.27.49_PM.png
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69662: Displayed resource provider information in
the Mesos webui.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69662/#review211825
-----------------------------------------------------------
PASS: Mesos patch 69662 was successfully built and tested.
Reviews applied: `['69661', '69662']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2749/mesos-review-69662
- Mesos Reviewbot Windows
On Jan. 10, 2019, 5:19 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69662/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2019, 5:19 p.m.)
>
>
> Review request for mesos, Armand Grillet, Benjamin Mahler, and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-8380
> https://issues.apache.org/jira/browse/MESOS-8380
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Displayed resource provider information in the Mesos webui.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html a101a93dcdb95f257fe0ee967c92d2cdc1c84f84
> src/webui/app/controllers.js 8049cf611895edea7c54b3c58d71e00d823a1fd3
>
>
> Diff: https://reviews.apache.org/r/69662/diff/5/
>
>
> Testing
> -------
>
> `make check`
>
> Ran a local test with a `./src/test-csi-plugin`.
>
>
> File Attachments
> ----------------
>
> Screenshot Agent screen
> https://reviews.apache.org/media/uploaded/files/2019/01/04/ed920e7b-4072-49be-8801-3b875d529fad__Screen_Shot_2019-01-04_at_11.11.51_AM.png
> Screenshot Agent screen
> https://reviews.apache.org/media/uploaded/files/2019/01/07/8f494c0f-1c76-4734-9aae-7fb899589120__Screen_Shot_2019-01-07_at_9.42.51_PM.png
> Screenshot Agent screen
> https://reviews.apache.org/media/uploaded/files/2019/01/07/8a850bcd-dd30-4d25-bb37-60cd872ddd62__Screen_Shot_2019-01-07_at_11.27.49_PM.png
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69662: Displayed resource provider information in
the Mesos webui.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69662/
-----------------------------------------------------------
(Updated Jan. 10, 2019, 10:19 a.m.)
Review request for mesos, Armand Grillet, Benjamin Mahler, and Chun-Hung Hsiao.
Changes
-------
Addressed remaining issues from bmahler and chhsia0.
Bugs: MESOS-8380
https://issues.apache.org/jira/browse/MESOS-8380
Repository: mesos
Description
-------
Displayed resource provider information in the Mesos webui.
Diffs (updated)
-----
src/webui/app/agents/agent.html a101a93dcdb95f257fe0ee967c92d2cdc1c84f84
src/webui/app/controllers.js 8049cf611895edea7c54b3c58d71e00d823a1fd3
Diff: https://reviews.apache.org/r/69662/diff/5/
Changes: https://reviews.apache.org/r/69662/diff/4-5/
Testing
-------
`make check`
Ran a local test with a `./src/test-csi-plugin`.
File Attachments
----------------
Screenshot Agent screen
https://reviews.apache.org/media/uploaded/files/2019/01/04/ed920e7b-4072-49be-8801-3b875d529fad__Screen_Shot_2019-01-04_at_11.11.51_AM.png
Screenshot Agent screen
https://reviews.apache.org/media/uploaded/files/2019/01/07/8f494c0f-1c76-4734-9aae-7fb899589120__Screen_Shot_2019-01-07_at_9.42.51_PM.png
Screenshot Agent screen
https://reviews.apache.org/media/uploaded/files/2019/01/07/8a850bcd-dd30-4d25-bb37-60cd872ddd62__Screen_Shot_2019-01-07_at_11.27.49_PM.png
Thanks,
Benjamin Bannier
Re: Review Request 69662: Displayed resource provider information in
the Mesos webui.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69662/#review211799
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['69661', '69662']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2732/mesos-review-69662
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2732/mesos-review-69662/logs/mesos-tests.log):
```
I0109 20:38:42.886330 4032 master.cpp:11159] Removing task b35b955c-a9cc-48fd-834d-1fbc15463cfe with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 34bb7ca4-4c9e-4124-98b1-243d8107abeb-0000 on agent 34bb7ca4-4c9e-4124-98b1-243d8107abeb-S0 at slave(464)@192.10.1.4:54459 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0109 20:38:42.889328 4032 master.cpp:1271] Agent 34bb7ca4-4c9e-4124-98b1-243d8107abeb-S0 at slave(464)@192.10.1.4:54459 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0109 20:38:42.889328 4032 master.cpp:3274] Disconnecting agent 34bb7ca4-4c9e-4124-98b1-243d8107abeb-S0 at slave(464)@192.10.1.4:54459 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0109 20:38:42.889328 4032 master.cpp:3293] Deactivating agent 34bb7ca4-4c9e-4124-98b1-243d8107abeb-S0 at slave(464)@192.10.1.4:54459 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0109 20:38:42.890322 2172 hierarchical.cpp:358] Removed framework 34bb7ca4-4c9e-4124-98b1-243d8107abeb-0000
I0109 20:38:42.890322 2172 hierarchical.cpp:802] Agent 34bb7ca4-4c9e-4124-98b1-243d8107abeb-S0 deactivated
I0109 20:38:42.891335 3124 containerizer.cpp:2469] Destroying container 56711a10-3af0-4094-842e-e62285fffa29 in RUNNING state
I0109 20:38:42.891335 3124 containerizer.cpp:3136] Transitioning the state of container 56711a10-3af0-4094-842e-e62285fffa29 from RUNNING to DESTROYING
I0109 20:38:42.891335 3124 launcher.cpp:161] Asked to destroy container 56711a10-3af0-4094-842e-e62285fffa29
W0109 20:38:42.893324 8116 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=2992 to peer '192.10.1.4:56254': IO failed with error [ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (687 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (706 ms total)
[----------] Global test environment tear-down
[==========] 1082 tests from 104 test cases ran. (498198 ms total)
[ PASSED ] 1081 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName
1 FAILED TEST
YOU HAVE 231 DISABLED TESTS
code: The specified network name is no longer available.
W0109 20:38:42.893324 8116 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=2480 to peer '192.10.1.4:56255': IO failed with error code: The specified network name is no longer available.
I0109 20:38:42.988771 2172 containerizer.cpp:2975] Container 56711a10-3af0-4094-842e-e62285fffa29 has exited
I0109 20:38:43.017823 3024 master.cpp:1111] Master terminating
I0109 20:38:43.018806 7256 hierarchical.cpp:644] Removed agent 34bb7ca4-4c9e-4124-98b1-243d8107abeb-S0
I0109 20:38:43.276753 8116 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Jan. 7, 2019, 11:33 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69662/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2019, 11:33 p.m.)
>
>
> Review request for mesos, Armand Grillet, Benjamin Mahler, and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-8380
> https://issues.apache.org/jira/browse/MESOS-8380
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Displayed resource provider information in the Mesos webui.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html a101a93dcdb95f257fe0ee967c92d2cdc1c84f84
> src/webui/app/controllers.js 8049cf611895edea7c54b3c58d71e00d823a1fd3
>
>
> Diff: https://reviews.apache.org/r/69662/diff/4/
>
>
> Testing
> -------
>
> `make check`
>
> Ran a local test with a `./src/test-csi-plugin`.
>
>
> File Attachments
> ----------------
>
> Screenshot Agent screen
> https://reviews.apache.org/media/uploaded/files/2019/01/04/ed920e7b-4072-49be-8801-3b875d529fad__Screen_Shot_2019-01-04_at_11.11.51_AM.png
> Screenshot Agent screen
> https://reviews.apache.org/media/uploaded/files/2019/01/07/8f494c0f-1c76-4734-9aae-7fb899589120__Screen_Shot_2019-01-07_at_9.42.51_PM.png
> Screenshot Agent screen
> https://reviews.apache.org/media/uploaded/files/2019/01/07/8a850bcd-dd30-4d25-bb37-60cd872ddd62__Screen_Shot_2019-01-07_at_11.27.49_PM.png
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69662: Displayed resource provider information in
the Mesos webui.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69662/#review211779
-----------------------------------------------------------
Fix it, then Ship it!
src/webui/app/controllers.js
Lines 714-717 (patched)
<https://reviews.apache.org/r/69662/#comment297385>
Is this something we do elsewhere with IDs? Is it because elsewhere we don't have value in the json? Feels unfortunate to have to mutate the structure of the json (I know we have done that in a few places but this seems like a mutation of structure rather than adding things)
Maybe at the very least if we do think we should do this here, we can add some context about it (e.g. json has value for this id but not others)
src/webui/app/controllers.js
Lines 722-723 (patched)
<https://reviews.apache.org/r/69662/#comment297386>
This seems not very readable (or at least I struggled a bit with it), can we use underscore js clone?
https://underscorejs.org/#clone
```
provider.total_resources_full = _.clone(provider.total_resources);
```
- Benjamin Mahler
On Jan. 7, 2019, 10:33 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69662/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2019, 10:33 p.m.)
>
>
> Review request for mesos, Armand Grillet, Benjamin Mahler, and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-8380
> https://issues.apache.org/jira/browse/MESOS-8380
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Displayed resource provider information in the Mesos webui.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html a101a93dcdb95f257fe0ee967c92d2cdc1c84f84
> src/webui/app/controllers.js 8049cf611895edea7c54b3c58d71e00d823a1fd3
>
>
> Diff: https://reviews.apache.org/r/69662/diff/4/
>
>
> Testing
> -------
>
> `make check`
>
> Ran a local test with a `./src/test-csi-plugin`.
>
>
> File Attachments
> ----------------
>
> Screenshot Agent screen
> https://reviews.apache.org/media/uploaded/files/2019/01/04/ed920e7b-4072-49be-8801-3b875d529fad__Screen_Shot_2019-01-04_at_11.11.51_AM.png
> Screenshot Agent screen
> https://reviews.apache.org/media/uploaded/files/2019/01/07/8f494c0f-1c76-4734-9aae-7fb899589120__Screen_Shot_2019-01-07_at_9.42.51_PM.png
> Screenshot Agent screen
> https://reviews.apache.org/media/uploaded/files/2019/01/07/8a850bcd-dd30-4d25-bb37-60cd872ddd62__Screen_Shot_2019-01-07_at_11.27.49_PM.png
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69662: Displayed resource provider information in
the Mesos webui.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69662/
-----------------------------------------------------------
(Updated Jan. 7, 2019, 11:33 p.m.)
Review request for mesos, Armand Grillet, Benjamin Mahler, and Chun-Hung Hsiao.
Changes
-------
Fixed attribute typo.
Bugs: MESOS-8380
https://issues.apache.org/jira/browse/MESOS-8380
Repository: mesos
Description
-------
Displayed resource provider information in the Mesos webui.
Diffs (updated)
-----
src/webui/app/agents/agent.html a101a93dcdb95f257fe0ee967c92d2cdc1c84f84
src/webui/app/controllers.js 8049cf611895edea7c54b3c58d71e00d823a1fd3
Diff: https://reviews.apache.org/r/69662/diff/4/
Changes: https://reviews.apache.org/r/69662/diff/3-4/
Testing
-------
`make check`
Ran a local test with a `./src/test-csi-plugin`.
File Attachments (updated)
----------------
Screenshot Agent screen
https://reviews.apache.org/media/uploaded/files/2019/01/04/ed920e7b-4072-49be-8801-3b875d529fad__Screen_Shot_2019-01-04_at_11.11.51_AM.png
Screenshot Agent screen
https://reviews.apache.org/media/uploaded/files/2019/01/07/8f494c0f-1c76-4734-9aae-7fb899589120__Screen_Shot_2019-01-07_at_9.42.51_PM.png
Screenshot Agent screen
https://reviews.apache.org/media/uploaded/files/2019/01/07/8a850bcd-dd30-4d25-bb37-60cd872ddd62__Screen_Shot_2019-01-07_at_11.27.49_PM.png
Thanks,
Benjamin Bannier
Re: Review Request 69662: Displayed resource provider information in
the Mesos webui.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69662/
-----------------------------------------------------------
(Updated Jan. 7, 2019, 10:02 p.m.)
Review request for mesos, Armand Grillet, Benjamin Mahler, and Chun-Hung Hsiao.
Changes
-------
Addressed issues raised by bmahler.
Bugs: MESOS-8380
https://issues.apache.org/jira/browse/MESOS-8380
Repository: mesos
Description
-------
Displayed resource provider information in the Mesos webui.
Diffs (updated)
-----
src/webui/app/agents/agent.html a101a93dcdb95f257fe0ee967c92d2cdc1c84f84
src/webui/app/controllers.js 8049cf611895edea7c54b3c58d71e00d823a1fd3
Diff: https://reviews.apache.org/r/69662/diff/3/
Changes: https://reviews.apache.org/r/69662/diff/2-3/
Testing
-------
`make check`
Ran a local test with a `./src/test-csi-plugin`.
File Attachments (updated)
----------------
Screenshot Agent screen
https://reviews.apache.org/media/uploaded/files/2019/01/04/ed920e7b-4072-49be-8801-3b875d529fad__Screen_Shot_2019-01-04_at_11.11.51_AM.png
Screenshot Agent screen
https://reviews.apache.org/media/uploaded/files/2019/01/07/8f494c0f-1c76-4734-9aae-7fb899589120__Screen_Shot_2019-01-07_at_9.42.51_PM.png
Thanks,
Benjamin Bannier
Re: Review Request 69662: Displayed resource provider information in
the Mesos webui.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Jan. 7, 2019, 7:14 p.m., Benjamin Mahler wrote:
> > src/webui/app/agents/agent.html
> > Lines 176-179 (patched)
> > <https://reviews.apache.org/r/69662/diff/2/?file=2117505#file2117505line176>
> >
> > Is this hidden if there are no providers? Can you show a screenshot of the entire agent UI rather than just a cropped version? One where there are no providers would be helpful as well (my inclination is to hide it in that case)
Hiding the table now if no resource providers are present.
During the transition period this might be confusing to users since it is hard to tell whether their UI does not display any resource providers, or if no resource providers are present, but hiding it is the right long-term solution and I believe acceptable for an experimental feature.
> On Jan. 7, 2019, 7:14 p.m., Benjamin Mahler wrote:
> > src/webui/app/agents/agent.html
> > Lines 184-186 (patched)
> > <https://reviews.apache.org/r/69662/diff/2/?file=2117505#file2117505line184>
> >
> > Do we actually expect resource providers to be providing cpus and mem? I would suggest removing these to simplify the UI
> >
> > Maybe at some point we want to show other resource names being provided? Maybe the column should just be 'Resources' and a stringified version is shown?
re:stringification, I am hesitant to put a stringified resource string into `/state`, and we currently do not provide a resource stringification function in the webui javascript code. As writing one would be a bigger undertaking (e.g., requiring extensive testing to ensure the javascript implementation stays in sync with what we use in Mesos), I'd prefer to punt on that for now; I could also imagine that we would eventually want a resource representation which exposes more low-level information (for SLRPs resources e.g., the individual disks and their metadata).
I am just exposing aggregated `disk` resources in the UI now since only storage resource providers are currently implemented (which I gratuitously assert only provide `disk` resources). I tried to add a `console.warn` to the controller code so that it warns should other resource kinds show up, but this is not allowed by the linter (and maybe not a good idea, either).
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69662/#review211732
-----------------------------------------------------------
On Jan. 7, 2019, 10:02 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69662/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2019, 10:02 p.m.)
>
>
> Review request for mesos, Armand Grillet, Benjamin Mahler, and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-8380
> https://issues.apache.org/jira/browse/MESOS-8380
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Displayed resource provider information in the Mesos webui.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html a101a93dcdb95f257fe0ee967c92d2cdc1c84f84
> src/webui/app/controllers.js 8049cf611895edea7c54b3c58d71e00d823a1fd3
>
>
> Diff: https://reviews.apache.org/r/69662/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
> Ran a local test with a `./src/test-csi-plugin`.
>
>
> File Attachments
> ----------------
>
> Screenshot Agent screen
> https://reviews.apache.org/media/uploaded/files/2019/01/04/ed920e7b-4072-49be-8801-3b875d529fad__Screen_Shot_2019-01-04_at_11.11.51_AM.png
> Screenshot Agent screen
> https://reviews.apache.org/media/uploaded/files/2019/01/07/8f494c0f-1c76-4734-9aae-7fb899589120__Screen_Shot_2019-01-07_at_9.42.51_PM.png
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69662: Displayed resource provider information in
the Mesos webui.
Posted by Benjamin Bannier <be...@mesosphere.io>.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69662/#review211732
-----------------------------------------------------------
On Jan. 7, 2019, 10:02 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69662/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2019, 10:02 p.m.)
>
>
> Review request for mesos, Armand Grillet, Benjamin Mahler, and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-8380
> https://issues.apache.org/jira/browse/MESOS-8380
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Displayed resource provider information in the Mesos webui.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html a101a93dcdb95f257fe0ee967c92d2cdc1c84f84
> src/webui/app/controllers.js 8049cf611895edea7c54b3c58d71e00d823a1fd3
>
>
> Diff: https://reviews.apache.org/r/69662/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
> Ran a local test with a `./src/test-csi-plugin`.
>
>
> File Attachments
> ----------------
>
> Screenshot Agent screen
> https://reviews.apache.org/media/uploaded/files/2019/01/04/ed920e7b-4072-49be-8801-3b875d529fad__Screen_Shot_2019-01-04_at_11.11.51_AM.png
> Screenshot Agent screen
> https://reviews.apache.org/media/uploaded/files/2019/01/07/8f494c0f-1c76-4734-9aae-7fb899589120__Screen_Shot_2019-01-07_at_9.42.51_PM.png
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69662: Displayed resource provider information in
the Mesos webui.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69662/#review211732
-----------------------------------------------------------
src/webui/app/agents/agent.html
Lines 176-179 (patched)
<https://reviews.apache.org/r/69662/#comment297310>
Is this hidden if there are no providers? Can you show a screenshot of the entire agent UI rather than just a cropped version? One where there are no providers would be helpful as well (my inclination is to hide it in that case)
src/webui/app/agents/agent.html
Lines 184-186 (patched)
<https://reviews.apache.org/r/69662/#comment297309>
Do we actually expect resource providers to be providing cpus and mem? I would suggest removing these to simplify the UI
Maybe at some point we want to show other resource names being provided? Maybe the column should just be 'Resources' and a stringified version is shown?
- Benjamin Mahler
On Jan. 4, 2019, 10:14 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69662/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2019, 10:14 a.m.)
>
>
> Review request for mesos, Armand Grillet, Benjamin Mahler, and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-8380
> https://issues.apache.org/jira/browse/MESOS-8380
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Displayed resource provider information in the Mesos webui.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html a101a93dcdb95f257fe0ee967c92d2cdc1c84f84
> src/webui/app/controllers.js 8049cf611895edea7c54b3c58d71e00d823a1fd3
>
>
> Diff: https://reviews.apache.org/r/69662/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
> Ran a local test with a `./src/test-csi-plugin`.
>
>
> File Attachments
> ----------------
>
> Screenshot Agent screen
> https://reviews.apache.org/media/uploaded/files/2019/01/04/ed920e7b-4072-49be-8801-3b875d529fad__Screen_Shot_2019-01-04_at_11.11.51_AM.png
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69662: Displayed resource provider information in
the Mesos webui.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69662/
-----------------------------------------------------------
(Updated Jan. 4, 2019, 11:14 a.m.)
Review request for mesos, Armand Grillet, Benjamin Mahler, and Chun-Hung Hsiao.
Changes
-------
Zero-initialized all common summarized resource kinds.
Bugs: MESOS-8380
https://issues.apache.org/jira/browse/MESOS-8380
Repository: mesos
Description
-------
Displayed resource provider information in the Mesos webui.
Diffs (updated)
-----
src/webui/app/agents/agent.html a101a93dcdb95f257fe0ee967c92d2cdc1c84f84
src/webui/app/controllers.js 8049cf611895edea7c54b3c58d71e00d823a1fd3
Diff: https://reviews.apache.org/r/69662/diff/2/
Changes: https://reviews.apache.org/r/69662/diff/1-2/
Testing
-------
`make check`
Ran a local test with a `./src/test-csi-plugin`.
File Attachments (updated)
----------------
Screenshot Agent screen
https://reviews.apache.org/media/uploaded/files/2019/01/04/ed920e7b-4072-49be-8801-3b875d529fad__Screen_Shot_2019-01-04_at_11.11.51_AM.png
Thanks,
Benjamin Bannier
Re: Review Request 69662: Displayed resource provider information in
the Mesos webui.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69662/#review211637
-----------------------------------------------------------
Ship it!
LGTM. The button logic is similar to what is in `agents.html` (that's a good thing).
- Armand Grillet
On Jan. 3, 2019, 4 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69662/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2019, 4 p.m.)
>
>
> Review request for mesos, Armand Grillet, Benjamin Mahler, and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-8380
> https://issues.apache.org/jira/browse/MESOS-8380
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Displayed resource provider information in the Mesos webui.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html a101a93dcdb95f257fe0ee967c92d2cdc1c84f84
> src/webui/app/controllers.js 8049cf611895edea7c54b3c58d71e00d823a1fd3
>
>
> Diff: https://reviews.apache.org/r/69662/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
> Ran a local test with a `./src/test-csi-plugin`.
>
>
> Thanks,
>
> Benjamin Bannier
>
>