[GitHub] spark pull request #22038: [SPARK-25056][SQL] Unify the InConversion and Bin...

[maropu <gi...@git.apache.org>]

Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22038#discussion_r217603577
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ---
    @@ -485,8 +494,8 @@ object TypeCoercion {
               i
             }
     
    -      case i @ In(a, b) if b.exists(_.dataType != a.dataType) =>
    -        findWiderCommonType(i.children.map(_.dataType)) match {
    +      case i @ In(value, list) if list.exists(_.dataType != value.dataType) =>
    +        findInCommonType(value.dataType, list.map(_.dataType), conf) match {
    --- End diff --
    
    If `findInCommonTyp` is used only for this case, can we inline the `findInCommonType`here?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org