You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/29 12:56:57 UTC

[GitHub] [spark] ocworld opened a new pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

ocworld opened a new pull request #32397:
URL: https://github.com/apache/spark/pull/32397


   ### What changes were proposed in this pull request?
   Supporting '--packages' in the k8s cluster mode
   
   ### Why are the changes needed?
   In spark 3, '--packages' in the k8s cluster mode is not supported. I expected that managing dependencies by using packages like spark 2.
   
   ### Does this PR introduce _any_ user-facing change?
   Unlike spark 2, resolved jars are added not in cluster mode spark submit but in driver.
   
   It's because in spark 3, the feature is added that is uploading jars with prefix "file://" to s3.
   So, if resolved jars are added in spark submit, every jars from packages are uploading to s3! When I tested it, it is very bad experience to me.
   
   ### How was this patch tested?
   In my k8s environment, i tested the code.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-853505471


   **[Test build #139256 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139256/testReport)** for PR 32397 at commit [`ee867e0`](https://github.com/apache/spark/commit/ee867e0ee3ca600cd26b9659bde826c6015ef250).
    * This patch **fails to build**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-831902366


   Can you rebase and force push in this PR to retrigger the build?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-850011679


   **[Test build #139038 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139038/testReport)** for PR 32397 at commit [`b47599f`](https://github.com/apache/spark/commit/b47599fe82a2b6d4cd3896c4117d3de19cc62d5e).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-853505497


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139256/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-830740047


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138137/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-850569995






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-831018332


   @ocworld can you take a look https://github.com/apache/spark/pull/32397/checks?check_run_id=2484554770 and enable Github Actions in your forked repository?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-865672677


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44650/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-890436539


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46433/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-850029505


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43556/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-832378107


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42679/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-850056962


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43556/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-865672677


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44650/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-853505497


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139256/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-850569995






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-830714990






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] GaruGaru commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
GaruGaru commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-957914768


   Any update on this ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-831913264


   did you do something like https://github.com/apache/spark/pull/32400#issuecomment-831051189? The GitHub Actions should run the build in your forked repository but it seems not.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ocworld commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
ocworld commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-838655508


   @dongjoon-hyun I reviewed "BasicTestsSuite" and "DepsTestsSuite"
   
   I think it is hard to add test case in it.
   
   It's because it is needed to get spark.jars in the running application's spark context on the driver pod. I don't have any idea about it, now.
   
   Do you have any idea about test?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-865636702


   **[Test build #140123 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140123/testReport)** for PR 32397 at commit [`e5d3e06`](https://github.com/apache/spark/commit/e5d3e06a3959b6404c200a346ca7018c3404d9ef).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-853530393


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43778/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-832383783


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138158/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-850067873






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-850469024


   **[Test build #139060 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139060/testReport)** for PR 32397 at commit [`8815f7c`](https://github.com/apache/spark/commit/8815f7c3a70901c7e953335fc0aed95346937e01).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-830722441


   **[Test build #138137 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138137/testReport)** for PR 32397 at commit [`31783a6`](https://github.com/apache/spark/commit/31783a697ad9db05b5b8e818ec5af5384d3b7b12).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] holdenk commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-867871484


   So I'm a little confused about the intention of the PR. If we have a package that we want to resolve in cluster mode we probably do need to put it on compatible filesystem so the workers can fetch the JARs. It's either that or have each worker fetch the resolved JARs and maybe I'm missing it but I don't see the logic for that here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-829244740


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-830716406


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42657/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-865742759


   **[Test build #140123 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140123/testReport)** for PR 32397 at commit [`e5d3e06`](https://github.com/apache/spark/commit/e5d3e06a3959b6404c200a346ca7018c3404d9ef).
    * This patch **fails PySpark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-875469723


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140744/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-853518838


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43778/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ocworld commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
ocworld commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-831884160


   @HyukjinKwon 
   
   ![image](https://user-images.githubusercontent.com/13185662/116999685-ed7bca80-ad1a-11eb-8314-98a5d1f004c3.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-875342768


   **[Test build #140744 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140744/testReport)** for PR 32397 at commit [`b25c787`](https://github.com/apache/spark/commit/b25c787aa128369c1b0ae5f4b05be942041597f8).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-853503230






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-875380798


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45253/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-865745955


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140123/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-853530414


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43778/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-832378107


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42679/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a change in pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32397:
URL: https://github.com/apache/spark/pull/32397#discussion_r625756478



##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
##########
@@ -308,21 +308,23 @@ private[spark] class SparkSubmit extends Logging {
         args.repositories, args.ivyRepoPath, args.ivySettingsPath)
 
       if (resolvedMavenCoordinates.nonEmpty) {
-        // In K8s client mode, when in the driver, add resolved jars early as we might need
-        // them at the submit time for artifact downloading.
-        // For example we might use the dependencies for downloading
-        // files from a Hadoop Compatible fs e.g. S3. In this case the user might pass:
-        // --packages com.amazonaws:aws-java-sdk:1.7.4:org.apache.hadoop:hadoop-aws:2.7.6
-        if (isKubernetesClusterModeDriver) {
-          val loader = getSubmitClassLoader(sparkConf)
-          for (jar <- resolvedMavenCoordinates) {
-            addJarToClasspath(jar, loader)
-          }
-        } else if (isKubernetesCluster) {
+        if (isKubernetesCluster) {
           // We need this in K8s cluster mode so that we can upload local deps
           // via the k8s application, like in cluster mode driver
           childClasspath ++= resolvedMavenCoordinates
         } else {
+          // In K8s client mode, when in the driver, resolved jars are added in the driver.
+          //

Review comment:
       ```suggestion
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] mridulm commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
mridulm commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-833609363


   +CC @shardulm94, @xkrogen 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ocworld commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
ocworld commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-831911041


   @HyukjinKwon I've already rebase and force push. So, now, everything is up-to-date.
   After merging others' some pr, i'll retry it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-902384464


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47160/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-865745955


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140123/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-865672646


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44650/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-902345804


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142659/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] GaruGaru commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
GaruGaru commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-957914768


   Any update on this ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] grcanosa commented on pull request #32397: [WIP][SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
grcanosa commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-1049132771


   Any news on when this is going to be merged?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-875381758


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45253/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-838665141


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42903/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-853503230


   **[Test build #139256 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139256/testReport)** for PR 32397 at commit [`ee867e0`](https://github.com/apache/spark/commit/ee867e0ee3ca600cd26b9659bde826c6015ef250).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-850560560


   **[Test build #139060 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139060/testReport)** for PR 32397 at commit [`8815f7c`](https://github.com/apache/spark/commit/8815f7c3a70901c7e953335fc0aed95346937e01).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-902345784


   **[Test build #142659 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142659/testReport)** for PR 32397 at commit [`554127b`](https://github.com/apache/spark/commit/554127b11daaab6377e69cff7956f5c6c38c2d62).
    * This patch **fails to build**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-830722441


   **[Test build #138137 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138137/testReport)** for PR 32397 at commit [`31783a6`](https://github.com/apache/spark/commit/31783a697ad9db05b5b8e818ec5af5384d3b7b12).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-890441157


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46433/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ocworld commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
ocworld commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-830720578


   @dongjoon-hyun Thank you for your test and reply.
   Though rebasing from upstream, checking build and test is failed now.
   Jenkins build is also failed with logs.
   
   ```
   Setting status of fe0a4b5625ffceaa6c81e9f63637214d08369642 to FAILURE with url https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42657/ and message: 'Build finished. '
   FileNotFoundException means that the credentials Jenkins is using is probably wrong. Or the user account does not have write access to the repo.
   org.kohsuke.github.GHFileNotFoundException: https://api.github.com/repos/apache/spark/statuses/fe0a4b5625ffceaa6c81e9f63637214d08369642 {"message":"Not Found","documentation_url":"https://docs.github.com/rest/reference/repos#create-a-commit-status"}
   	at org.kohsuke.github.GitHubClient.interpretApiError(GitHubClient.java:492)
   	at org.kohsuke.github.GitHubClient.sendRequest(GitHubClient.java:420)
   	at org.kohsuke.github.GitHubClient.sendRequest(GitHubClient.java:363)
   	at org.kohsuke.github.Requester.fetch(Requester.java:74)
   	at org.kohsuke.github.GHRepository.createCommitStatus(GHRepository.java:1906)
   	at org.jenkinsci.plugins.ghprb.extensions.status.GhprbSimpleStatus.createCommitStatus(GhprbSimpleStatus.java:283)
   	at org.jenkinsci.plugins.ghprb.extensions.status.GhprbSimpleStatus.onBuildComplete(GhprbSimpleStatus.java:241)
   	at org.jenkinsci.plugins.ghprb.GhprbBuilds.onCompleted(GhprbBuilds.java:205)
   	at org.jenkinsci.plugins.ghprb.GhprbBuildListener.onCompleted(GhprbBuildListener.java:28)
   	at hudson.model.listeners.RunListener.fireCompleted(RunListener.java:209)
   	at hudson.model.Run.execute(Run.java:1952)
   	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
   	at hudson.model.ResourceController.execute(ResourceController.java:97)
   	at hudson.model.Executor.run(Executor.java:429)
   Caused by: java.io.FileNotFoundException: https://api.github.com/repos/apache/spark/statuses/fe0a4b5625ffceaa6c81e9f63637214d08369642
   	at sun.reflect.GeneratedConstructorAccessor1029.newInstance(Unknown Source)
   	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
   	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
   	at sun.net.www.protocol.http.HttpURLConnection$10.run(HttpURLConnection.java:1950)
   	at sun.net.www.protocol.http.HttpURLConnection$10.run(HttpURLConnection.java:1945)
   	at java.security.AccessController.doPrivileged(Native Method)
   	at sun.net.www.protocol.http.HttpURLConnection.getChainedException(HttpURLConnection.java:1944)
   	at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1514)
   	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1498)
   	at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:268)
   	at org.kohsuke.github.GitHubHttpUrlConnectionClient$HttpURLConnectionResponseInfo.bodyStream(GitHubHttpUrlConnectionClient.java:197)
   	at org.kohsuke.github.GitHubResponse$ResponseInfo.getBodyAsString(GitHubResponse.java:326)
   	at org.kohsuke.github.GitHubResponse.parseBody(GitHubResponse.java:91)
   	at org.kohsuke.github.Requester.lambda$fetch$1(Requester.java:74)
   	at org.kohsuke.github.GitHubClient.createResponse(GitHubClient.java:461)
   	at org.kohsuke.github.GitHubClient.sendRequest(GitHubClient.java:412)
   	... 12 more
   Caused by: java.io.FileNotFoundException: https://api.github.com/repos/apache/spark/statuses/fe0a4b5625ffceaa6c81e9f63637214d08369642
   	at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1896)
   	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1498)
   	at java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:480)
   	at sun.net.www.protocol.https.HttpsURLConnectionImpl.getResponseCode(HttpsURLConnectionImpl.java:352)
   	at org.kohsuke.github.GitHubHttpUrlConnectionClient.getResponseInfo(GitHubHttpUrlConnectionClient.java:69)
   	at org.kohsuke.github.GitHubClient.sendRequest(GitHubClient.java:400)
   	... 12 more
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ocworld commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
ocworld commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-829222299


   Can I see logs about failure of build and test?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-850058005


   **[Test build #139038 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139038/testReport)** for PR 32397 at commit [`b47599f`](https://github.com/apache/spark/commit/b47599fe82a2b6d4cd3896c4117d3de19cc62d5e).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ocworld commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
ocworld commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-831918776


   @HyukjinKwon Oh! you're right.  Workflow in actions tab was not activated. It is enabled now. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-902384464


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47160/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-875319011


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-890442676


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46433/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-830730568






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-830736790


   **[Test build #138137 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138137/testReport)** for PR 32397 at commit [`31783a6`](https://github.com/apache/spark/commit/31783a697ad9db05b5b8e818ec5af5384d3b7b12).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-829244740


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-853530414


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43778/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-902343695


   **[Test build #142659 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142659/testReport)** for PR 32397 at commit [`554127b`](https://github.com/apache/spark/commit/554127b11daaab6377e69cff7956f5c6c38c2d62).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-865666352


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44650/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-838821428


   **[Test build #138380 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138380/testReport)** for PR 32397 at commit [`76bdccc`](https://github.com/apache/spark/commit/76bdccc4c9dab7d2558e1b162590b6a9187daeff).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-853505497






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-830707293






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-838627447


   Kubernetes integration test unable to build dist.
   
   exiting with code: 1
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42903/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-830727039


   **[Test build #138136 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138136/testReport)** for PR 32397 at commit [`fe0a4b5`](https://github.com/apache/spark/commit/fe0a4b5625ffceaa6c81e9f63637214d08369642).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-850011679


   **[Test build #139038 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139038/testReport)** for PR 32397 at commit [`b47599f`](https://github.com/apache/spark/commit/b47599fe82a2b6d4cd3896c4117d3de19cc62d5e).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-865672677


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44650/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-853503230


   **[Test build #139256 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139256/testReport)** for PR 32397 at commit [`ee867e0`](https://github.com/apache/spark/commit/ee867e0ee3ca600cd26b9659bde826c6015ef250).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-875342768


   **[Test build #140744 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140744/testReport)** for PR 32397 at commit [`b25c787`](https://github.com/apache/spark/commit/b25c787aa128369c1b0ae5f4b05be942041597f8).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-875399320


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45255/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-838564651


   **[Test build #138380 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138380/testReport)** for PR 32397 at commit [`76bdccc`](https://github.com/apache/spark/commit/76bdccc4c9dab7d2558e1b162590b6a9187daeff).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ocworld edited a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
ocworld edited a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-830720578


   @dongjoon-hyun Thank you for your test and reply.
   Though rebasing from upstream, checking build and test is failed now.
   The jenkins build is also failed with logs.
   
   ```
   Setting status of fe0a4b5625ffceaa6c81e9f63637214d08369642 to FAILURE with url https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42657/ and message: 'Build finished. '
   FileNotFoundException means that the credentials Jenkins is using is probably wrong. Or the user account does not have write access to the repo.
   org.kohsuke.github.GHFileNotFoundException: https://api.github.com/repos/apache/spark/statuses/fe0a4b5625ffceaa6c81e9f63637214d08369642 {"message":"Not Found","documentation_url":"https://docs.github.com/rest/reference/repos#create-a-commit-status"}
   	at org.kohsuke.github.GitHubClient.interpretApiError(GitHubClient.java:492)
   	at org.kohsuke.github.GitHubClient.sendRequest(GitHubClient.java:420)
   	at org.kohsuke.github.GitHubClient.sendRequest(GitHubClient.java:363)
   	at org.kohsuke.github.Requester.fetch(Requester.java:74)
   	at org.kohsuke.github.GHRepository.createCommitStatus(GHRepository.java:1906)
   	at org.jenkinsci.plugins.ghprb.extensions.status.GhprbSimpleStatus.createCommitStatus(GhprbSimpleStatus.java:283)
   	at org.jenkinsci.plugins.ghprb.extensions.status.GhprbSimpleStatus.onBuildComplete(GhprbSimpleStatus.java:241)
   	at org.jenkinsci.plugins.ghprb.GhprbBuilds.onCompleted(GhprbBuilds.java:205)
   	at org.jenkinsci.plugins.ghprb.GhprbBuildListener.onCompleted(GhprbBuildListener.java:28)
   	at hudson.model.listeners.RunListener.fireCompleted(RunListener.java:209)
   	at hudson.model.Run.execute(Run.java:1952)
   	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
   	at hudson.model.ResourceController.execute(ResourceController.java:97)
   	at hudson.model.Executor.run(Executor.java:429)
   Caused by: java.io.FileNotFoundException: https://api.github.com/repos/apache/spark/statuses/fe0a4b5625ffceaa6c81e9f63637214d08369642
   	at sun.reflect.GeneratedConstructorAccessor1029.newInstance(Unknown Source)
   	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
   	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
   	at sun.net.www.protocol.http.HttpURLConnection$10.run(HttpURLConnection.java:1950)
   	at sun.net.www.protocol.http.HttpURLConnection$10.run(HttpURLConnection.java:1945)
   	at java.security.AccessController.doPrivileged(Native Method)
   	at sun.net.www.protocol.http.HttpURLConnection.getChainedException(HttpURLConnection.java:1944)
   	at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1514)
   	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1498)
   	at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:268)
   	at org.kohsuke.github.GitHubHttpUrlConnectionClient$HttpURLConnectionResponseInfo.bodyStream(GitHubHttpUrlConnectionClient.java:197)
   	at org.kohsuke.github.GitHubResponse$ResponseInfo.getBodyAsString(GitHubResponse.java:326)
   	at org.kohsuke.github.GitHubResponse.parseBody(GitHubResponse.java:91)
   	at org.kohsuke.github.Requester.lambda$fetch$1(Requester.java:74)
   	at org.kohsuke.github.GitHubClient.createResponse(GitHubClient.java:461)
   	at org.kohsuke.github.GitHubClient.sendRequest(GitHubClient.java:412)
   	... 12 more
   Caused by: java.io.FileNotFoundException: https://api.github.com/repos/apache/spark/statuses/fe0a4b5625ffceaa6c81e9f63637214d08369642
   	at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1896)
   	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1498)
   	at java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:480)
   	at sun.net.www.protocol.https.HttpsURLConnectionImpl.getResponseCode(HttpsURLConnectionImpl.java:352)
   	at org.kohsuke.github.GitHubHttpUrlConnectionClient.getResponseInfo(GitHubHttpUrlConnectionClient.java:69)
   	at org.kohsuke.github.GitHubClient.sendRequest(GitHubClient.java:400)
   	... 12 more
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-875425963


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45255/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-902378474


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47160/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-830707569


   > Can I see logs about failure of build and test?
   
   Apache Spark GitHub Action is running in your GitHub Account.
   
   <img width="847" alt="Screen Shot 2021-05-01 at 4 11 15 PM" src="https://user-images.githubusercontent.com/9700541/116797196-dd07ed80-aa97-11eb-9405-d2c4c4683a91.png">
   
   If you click the failure link, you can see the error log in your repo. The current failure occurs because your master branch is too outdate. Please follow the guideline to sync your master branch.
   - https://github.com/apache/spark/pull/32397/checks?check_run_id=2466811890
   ```
   Unable to detect the workflow run for testing the changes in your PR.
   
   If you did not enable GitHub Actions in your forked repository, please enable it. See also Disabling or limiting GitHub Actions for a repository for more details.
   It is possible your branch is based on the old master branch in Apache Spark, please sync your branch to the latest master branch. For example as below:
   git fetch upstream
   git rebase upstream/master
   git push origin YOUR_BRANCH --force
   ```
   
   In addition, I also triggered Jenkins machine too. For those users, we have another test machine additionally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-875374113


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45255/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] holdenk commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-877329511


   I think we really need integration tests for this, would you be up for me to making a PR to your branch to add integration tests?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ocworld commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
ocworld commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-829218585


   @AhnLab-OSS


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-850469024


   **[Test build #139060 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139060/testReport)** for PR 32397 at commit [`8815f7c`](https://github.com/apache/spark/commit/8815f7c3a70901c7e953335fc0aed95346937e01).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-850558529


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43581/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-875466221


   **[Test build #140744 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140744/testReport)** for PR 32397 at commit [`b25c787`](https://github.com/apache/spark/commit/b25c787aa128369c1b0ae5f4b05be942041597f8).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-838564651


   **[Test build #138380 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138380/testReport)** for PR 32397 at commit [`76bdccc`](https://github.com/apache/spark/commit/76bdccc4c9dab7d2558e1b162590b6a9187daeff).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-902359922


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47160/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-830730568






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-838665141


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42903/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-832383236


   **[Test build #138158 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138158/testReport)** for PR 32397 at commit [`bc366a9`](https://github.com/apache/spark/commit/bc366a9b510175c78c1bb95a3d1f10e7b5bc2d36).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-832328004


   **[Test build #138158 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138158/testReport)** for PR 32397 at commit [`bc366a9`](https://github.com/apache/spark/commit/bc366a9b510175c78c1bb95a3d1f10e7b5bc2d36).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-830716406


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42657/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-830710298


   **[Test build #138136 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138136/testReport)** for PR 32397 at commit [`fe0a4b5`](https://github.com/apache/spark/commit/fe0a4b5625ffceaa6c81e9f63637214d08369642).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-875381758


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45253/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ocworld commented on pull request #32397: [WIP][SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
ocworld commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-1050863228


   > Any news on when this is going to be merged?
   
   It is not merged now. I've tried to add test. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-830729189






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ocworld commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
ocworld commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-875328964


   @holdenk Now, I have no idea about checking jars resolved and downloaded in code in kube integrate test. So, it is only tested in my system and my k8s spark env.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-850067873






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-832383783


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138158/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] GaruGaru commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
GaruGaru commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-957914768


   Any update on this ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-832328004


   **[Test build #138158 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138158/testReport)** for PR 32397 at commit [`bc366a9`](https://github.com/apache/spark/commit/bc366a9b510175c78c1bb95a3d1f10e7b5bc2d36).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-850507242


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43581/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-875469723


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140744/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a change in pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32397:
URL: https://github.com/apache/spark/pull/32397#discussion_r625747983



##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
##########
@@ -308,21 +308,23 @@ private[spark] class SparkSubmit extends Logging {
         args.repositories, args.ivyRepoPath, args.ivySettingsPath)
 
       if (resolvedMavenCoordinates.nonEmpty) {
-        // In K8s client mode, when in the driver, add resolved jars early as we might need
-        // them at the submit time for artifact downloading.
-        // For example we might use the dependencies for downloading
-        // files from a Hadoop Compatible fs e.g. S3. In this case the user might pass:
-        // --packages com.amazonaws:aws-java-sdk:1.7.4:org.apache.hadoop:hadoop-aws:2.7.6
-        if (isKubernetesClusterModeDriver) {
-          val loader = getSubmitClassLoader(sparkConf)
-          for (jar <- resolvedMavenCoordinates) {
-            addJarToClasspath(jar, loader)
-          }
-        } else if (isKubernetesCluster) {
+        if (isKubernetesCluster) {
           // We need this in K8s cluster mode so that we can upload local deps
           // via the k8s application, like in cluster mode driver
           childClasspath ++= resolvedMavenCoordinates
         } else {
+          // In K8s client mode, when in the driver, resolved jars are added in the driver.
+          //
+          // For example we might use the dependencies for downloading

Review comment:
       ```suggestion
             // For example, we might use the dependencies for downloading
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-853505497






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-890430793


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-902345804


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142659/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-838856366


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138380/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-875319011


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-902343695


   **[Test build #142659 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142659/testReport)** for PR 32397 at commit [`554127b`](https://github.com/apache/spark/commit/554127b11daaab6377e69cff7956f5c6c38c2d62).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-875356186


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45253/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-875425963


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45255/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-865636702






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-838856366


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138380/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-865672677


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44650/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-832376946






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-865636702


   **[Test build #140123 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140123/testReport)** for PR 32397 at commit [`e5d3e06`](https://github.com/apache/spark/commit/e5d3e06a3959b6404c200a346ca7018c3404d9ef).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-890430793






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-830710298


   **[Test build #138136 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138136/testReport)** for PR 32397 at commit [`fe0a4b5`](https://github.com/apache/spark/commit/fe0a4b5625ffceaa6c81e9f63637214d08369642).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-853503230


   **[Test build #139256 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139256/testReport)** for PR 32397 at commit [`ee867e0`](https://github.com/apache/spark/commit/ee867e0ee3ca600cd26b9659bde826c6015ef250).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] holdenk commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-867892496


   Ah wait now I'm remembering, we serve the files from the driver to the workers. So yeah the design makes more sense than I thought originally.
   
   +1 on more testing though. We could add a package and then try and load it in the Kube integration tests if doing the manual deps testing is too complicated?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ocworld commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
ocworld commented on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-831880854


   @HyukjinKwon Github actions setting is enabled as allow all actions in my forked repository.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a change in pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32397:
URL: https://github.com/apache/spark/pull/32397#discussion_r625747504



##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
##########
@@ -308,21 +308,23 @@ private[spark] class SparkSubmit extends Logging {
         args.repositories, args.ivyRepoPath, args.ivySettingsPath)
 
       if (resolvedMavenCoordinates.nonEmpty) {
-        // In K8s client mode, when in the driver, add resolved jars early as we might need
-        // them at the submit time for artifact downloading.
-        // For example we might use the dependencies for downloading
-        // files from a Hadoop Compatible fs e.g. S3. In this case the user might pass:
-        // --packages com.amazonaws:aws-java-sdk:1.7.4:org.apache.hadoop:hadoop-aws:2.7.6
-        if (isKubernetesClusterModeDriver) {
-          val loader = getSubmitClassLoader(sparkConf)
-          for (jar <- resolvedMavenCoordinates) {
-            addJarToClasspath(jar, loader)
-          }
-        } else if (isKubernetesCluster) {
+        if (isKubernetesCluster) {
           // We need this in K8s cluster mode so that we can upload local deps

Review comment:
       ```suggestion
   ```

##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
##########
@@ -308,21 +308,23 @@ private[spark] class SparkSubmit extends Logging {
         args.repositories, args.ivyRepoPath, args.ivySettingsPath)
 
       if (resolvedMavenCoordinates.nonEmpty) {

Review comment:
       ```suggestion
         if (resolvedMavenCoordinates.nonEmpty) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32397:
URL: https://github.com/apache/spark/pull/32397#issuecomment-830740047


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138137/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org