You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "jglick (via GitHub)" <gi...@apache.org> on 2025/08/13 18:15:17 UTC
[PR] Define `mod-record-declaration` in `fontsColors.xml` [netbeans]
jglick opened a new pull request, #8732:
URL: https://github.com/apache/netbeans/pull/8732
I have started to use `record`s a lot recently, and am always irritated when their declarations are not colored like other types. The semantic parsing support seemed to be there, and the highlighting type was even defined, it was just not bound to anything.
---
<details open>
<summary>Click to collapse/expand PR instructions</summary>
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
### PR approval and merge checklist:
1. [ ] Was this PR [correctly labeled](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240884239#PRsandYouAreviewerGuide-PRtriggeredCIJobs(conditionalCIpipeline)), did the right tests run? When did they run?
2. [ ] Is this PR [squashed](https://cwiki.apache.org/confluence/display/NETBEANS/git%3A+squash+and+merge)?
3. [ ] Are author name / email address correct? Are [co-authors](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line) correctly listed? Do the commit messages need updates?
3. [ ] Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?
If this PR targets the delivery branch: [don't merge](https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery). ([full wiki article](https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide))
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Define `mod-record-declaration` in `fontsColors.xml` [netbeans]
Posted by "jglick (via GitHub)" <gi...@apache.org>.
jglick commented on PR #8732:
URL: https://github.com/apache/netbeans/pull/8732#issuecomment-3188854115
> NetBeans switches between them if you change the LAF from light to dark.
Like, at the OS level? Does not happen on Linux/GNOME at least. Anyway I tested just selecting those profiles from the dropdown in **Options**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Define `mod-record-declaration` in Java editor themes [netbeans]
Posted by "jglick (via GitHub)" <gi...@apache.org>.
jglick commented on PR #8732:
URL: https://github.com/apache/netbeans/pull/8732#issuecomment-3188907769
OK, do not recall ever seeing this tab. Seems to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Define `mod-record-declaration` in Java editor themes [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8732:
URL: https://github.com/apache/netbeans/pull/8732#issuecomment-3188873347
the editor profile is switched with the LAF theme if you change the LAF via options:
<img width="591" height="284" alt="image" src="https://github.com/user-attachments/assets/1be4624a-2621-4985-bbec-a8e62a348080" />
or dashboard:
<img width="329" height="245" alt="image" src="https://github.com/user-attachments/assets/816cc5d0-a34e-472f-a9c0-a90e678d93f4" />
FlatLaf Light/Dark have their corresponding editor color profiles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Define `mod-record-declaration` in `fontsColors.xml` [netbeans]
Posted by "jglick (via GitHub)" <gi...@apache.org>.
jglick commented on PR #8732:
URL: https://github.com/apache/netbeans/pull/8732#issuecomment-3188793775
Was able to “fix” `FlatLafDark` but struggling to understand how e.g. `CityLights` work, which apparently have a completely different scheme and layout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Define `mod-record-declaration` in Java editor themes [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #8732:
URL: https://github.com/apache/netbeans/pull/8732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Define `mod-record-declaration` in `fontsColors.xml` [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8732:
URL: https://github.com/apache/netbeans/pull/8732#issuecomment-3188837192
I think the two color profiles we should concentrate on are FlatLaf Light and Dark. Since NetBeans switches between them if you change the LAF from light to dark.
Thanks for updating the other profiles too! Can you squash everything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Define `mod-record-declaration` in Java editor themes [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8732:
URL: https://github.com/apache/netbeans/pull/8732#issuecomment-3188995888
> OK, do not recall ever seeing this tab.
its from the dashboard which replaced the welcome page https://github.com/apache/netbeans/pull/7239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Define `mod-record-declaration` in `fontsColors.xml` [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8732:
URL: https://github.com/apache/netbeans/pull/8732#issuecomment-3188675565
Right, found the reason. There are differences between light and dark themes. The dark theme doesn't render type names bold (unless its an interface with impl it seems), only the light theme.
So this would need tweaks or records would be the only bold declaration in the dark theme. I personally wouldn't mind if the dark theme would render type names in bold too and be more consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Define `mod-record-declaration` in `fontsColors.xml` [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8732:
URL: https://github.com/apache/netbeans/pull/8732#issuecomment-3188651533
oh. good catch! For some reason I never noticed this since I have a slightly customized theme which already renders it bold (I might have fixed this manually without noticing).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Define `mod-record-declaration` in `fontsColors.xml` [netbeans]
Posted by "jglick (via GitHub)" <gi...@apache.org>.
jglick commented on PR #8732:
URL: https://github.com/apache/netbeans/pull/8732#issuecomment-3188722419
> this would need tweaks or records would be the only bold declaration in the dark theme
https://github.com/apache/netbeans/blob/4015d0ed08ddc88d8df99f47c19adbdaeeffbfa8/java/java.editor/src/org/netbeans/modules/java/editor/resources/fontsColors.xml#L57-L59 etc. are using the exact same font style. This PR is just making `record XXX` behave the same as `class XXX`, `interface XXX`, `enum XXX`, etc.
I can confirm that `class XXX` is _not_ boldfaced in dark theme but I do not see where that is defined (and am not sure _why_ that would have been desirable to begin with).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Define `mod-record-declaration` in `fontsColors.xml` [netbeans]
Posted by "jglick (via GitHub)" <gi...@apache.org>.
jglick commented on PR #8732:
URL: https://github.com/apache/netbeans/pull/8732#issuecomment-3188734145
Ah because it gets overridden. Still seems weird and unwanted, but I can at least make it consistent :shrug:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Define `mod-record-declaration` in `fontsColors.xml` [netbeans]
Posted by "jglick (via GitHub)" <gi...@apache.org>.
jglick commented on PR #8732:
URL: https://github.com/apache/netbeans/pull/8732#issuecomment-3188822577
I think I have made `record` be consistent with `class` in all the themes shown in the dropdown. They do not behave consistently on `class` with respect to one another.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Define `mod-record-declaration` in `fontsColors.xml` [netbeans]
Posted by "jglick (via GitHub)" <gi...@apache.org>.
jglick commented on PR #8732:
URL: https://github.com/apache/netbeans/pull/8732#issuecomment-3188808635
Also the themes in `ide/defaults` have distinct schemes _from each other_. Seems unmaintained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists