[GitHub] zentol commented on issue #7456: [FLINK-11289][examples] Rework examples to account for licensing

[GitBox <gi...@apache.org>]

zentol commented on issue #7456: [FLINK-11289][examples] Rework examples to account for licensing 
URL: https://github.com/apache/flink/pull/7456#issuecomment-454733763
 
 
   My initial intention was to do exactly that; have these examples in separate modules, but doing so brought up a few other issues that I didn't want to deal with right now. I already blew significantly more time on this than I initially intended.
   
   The twitter-example also has a scala version, so I would've had to copy our array of scala plugin plugin configurations (why are they not in the plugin management?...), and I didn't really want to bother with that. There's also the `StreamingExamplesITCase` that runs the Twitter example which I would've had to account for _in some way_. You'd also have to change the module-structure, as the twitter/statemachine examples _should_ be children of `flink-examples-streaming`, but then you need also need a new module for the remaining ones.
   Finally, while it would simplify the shade configuration there's the question whether we should split up the example code for the sake of packaging.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services