[jira] [Comment Edited] (HBASE-11894) MetaEntries from coprocessor hooks in split and merge are not getting added to hbase:meta after HBASE-11611

["rajeshbabu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-11894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14125339#comment-14125339 ] 

rajeshbabu edited comment on HBASE-11894 at 9/8/14 9:25 AM:
------------------------------------------------------------

bq. Do we need to handle similar requirements for other transition codes? 
Just we need to handle for SPLIT_PONR and MERGE_PONR only Jimmy.

bq. How to describe these transitions we report the master such that it can make sense of them? Is master recording these ops critical or is it ok if they are dropped?
The interface required for reporting existing transition(SPLIT_PONR and MERGE_PONR) only stack. These meta ops are important to ensure data region and index region split atomiticity in Phoenix local indexing(https://github.com/apache/phoenix/blob/4.0/phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/LocalIndexSplitter.java). 
Thanks.


was (Author: rajesh23):
bq. Do we need to handle similar requirements for other transition codes? 
Just we need to handle for SPLIT_PONR and MERGE_PONR only Jimmy.

bq. How to describe these transitions we report the master such that it can make sense of them? Is master recording these ops critical or is it ok if they are dropped?
These are existing transitions only Stack. These meta ops are important to ensure data region and index region split atomiticity. Passing the meta entries of index region split updates through coprocessor hooks in Phoenix(0.98+ onwards).

> MetaEntries from coprocessor hooks in split and merge are not getting added to hbase:meta after HBASE-11611
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-11894
>                 URL: https://issues.apache.org/jira/browse/HBASE-11894
>             Project: HBase
>          Issue Type: Bug
>          Components: Region Assignment
>            Reporter: rajeshbabu
>            Assignee: rajeshbabu
>             Fix For: 2.0.0
>
>
> As part of HBASE-9249 & HBASE-9489, added new hooks in split and merge which take meta entries from coprocessor hooks if any. These meta entries helps to ensure atomicity of split(merge) of regions by server and split(merge) of the regions handled in coprocessors(This is required in secondary indexing case).
> After HBASE-11611 the meta entries are not getting added to meta both in split and merge.
> {code}
>     @MetaMutationAnnotation
>     List<Mutation> metaEntries = new ArrayList<Mutation>();
>     if (rsCoprocessorHost != null) {
>       if (rsCoprocessorHost.preMergeCommit(this.region_a, this.region_b, metaEntries)) {
>         throw new IOException("Coprocessor bypassing regions " + this.region_a + " "
>             + this.region_b + " merge.");
>       }
>       try {
>         for (Mutation p : metaEntries) {
>           HRegionInfo.parseRegionName(p.getRow());
>         }
>       } catch (IOException e) {
>         LOG.error("Row key of mutation from coprocessor is not parsable as region name."
>             + "Mutations from coprocessor should only be for hbase:meta table.", e);
>         throw e;
>       }
>     }
>     // This is the point of no return. Similar with SplitTransaction.
>     // IF we reach the PONR then subsequent failures need to crash out this
>     // regionserver
>     this.journal.add(JournalEntry.PONR);
>     // Add merged region and delete region_a and region_b
>     // as an atomic update. See HBASE-7721. This update to hbase:meta makes the region
>     // will determine whether the region is merged or not in case of failures.
>     // If it is successful, master will roll-forward, if not, master will
>     // rollback
>     if (services != null && !services.reportRegionStateTransition(TransitionCode.MERGE_PONR,
>         mergedRegionInfo, region_a.getRegionInfo(), region_b.getRegionInfo())) {
>       // Passed PONR, let SSH clean it up
>       throw new IOException("Failed to notify master that merge passed PONR: "
>         + region_a.getRegionInfo().getRegionNameAsString() + " and "
>         + region_b.getRegionInfo().getRegionNameAsString());
>     }
> {code}
> I think while reporting region state transition to master we need to pass meta entries also so that we can add them to meta along with split or merge updates.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)