[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1045: chore(build): remove the auto-generated Java code by thrift compiler

[GitBox <gi...@apache.org>]

acelyc111 commented on code in PR #1045:
URL: https://github.com/apache/incubator-pegasus/pull/1045#discussion_r919564617


##########
java-client/idl/recompile_thrift.sh:
##########
@@ -19,21 +19,28 @@
 # under the License.
 #
 
-# method to get thrift 0.11.0:
-#   wget http://mirrors.tuna.tsinghua.edu.cn/apache/thrift/0.11.0/thrift-0.11.0.tar.gz
-#   tar xvf thrift-0.11.0.tar.gz
-#   cd thrift-0.11.0
-#   ./configure --with-csharp=no --with-java=no --with-python=no --with-erlang=no --with-perl=no \
-#       --with-php=no --with-ruby=no --with-haskell=no --with-php_extension=no --with-rs=no --with-go=no
-#   make
-#   sudo make install
-# 
-# Note: by default the thrift will be installed in /usr/local. If you'd like to install it somewhere else,
-# you'd better provide install path with option `--prefix=xxx'.
- 
+function GenThriftTool() {
+  wget http://mirrors.tuna.tsinghua.edu.cn/apache/thrift/0.11.0/thrift-0.11.0.tar.gz
+  tar xvf thrift-0.11.0.tar.gz
+  cd thrift-0.11.0
+  ./configure --with-csharp=no --with-java=no --with-python=no --with-erlang=no --with-perl=no \
+      --with-php=no --with-ruby=no --with-haskell=no --with-php_extension=no --with-rs=no --with-go=no
+  make

Review Comment:
   leave some CPU resource for other purpose



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org