You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/03 12:05:03 UTC
[GitHub] [flink-connector-elasticsearch] MartijnVisser opened a new pull request, #15: [FLINK-27475][Build] Clean-up unused Maven dependencies, plugins and profiles
MartijnVisser opened a new pull request, #15:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/15
* First iteration of clean-up of Maven POM files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] afedulov commented on a diff in pull request #15: [FLINK-27475][Build] Clean-up unused Maven dependencies, plugins and profiles
Posted by GitBox <gi...@apache.org>.
afedulov commented on code in PR #15:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/15#discussion_r863822433
##########
flink-connector-elasticsearch7/pom.xml:
##########
@@ -81,20 +81,6 @@ under the License.
<groupId>org.elasticsearch.client</groupId>
<artifactId>elasticsearch-rest-high-level-client</artifactId>
<version>${elasticsearch.version}</version>
- <!-- elasticsearch-rest-client includes two different versions of httpcore-nio -->
- <exclusions>
- <exclusion>
- <groupId>org.apache.httpcomponents</groupId>
- <artifactId>httpcore-nio</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
-
- <!-- We need to include httpcore-nio again in the correct version due to the exclusion above -->
- <dependency>
Review Comment:
Without this and the exclusion the original Flink CI would fail with a dependencies convergence error.
You can run in the original repo with `mvn validate -Pcheck-convergence` and maven 3.2.5.
The issue is that their client bundles two versions of the httpcomponents. I would say such dependency convergence test is in general a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] alpreu commented on a diff in pull request #15: [FLINK-27475][Build] Clean-up unused Maven dependencies, plugins and profiles
Posted by GitBox <gi...@apache.org>.
alpreu commented on code in PR #15:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/15#discussion_r871187621
##########
pom.xml:
##########
@@ -393,67 +338,13 @@ under the License.
<version>3.3.2</version>
</dependency>
- <dependency>
- <groupId>org.xerial.snappy</groupId>
- <artifactId>snappy-java</artifactId>
- <version>1.1.8.3</version>
- </dependency>
-
- <dependency>
- <groupId>org.lz4</groupId>
- <artifactId>lz4-java</artifactId>
- <version>${lz4.version}</version>
- </dependency>
-
- <dependency>
- <groupId>com.github.oshi</groupId>
- <artifactId>oshi-core</artifactId>
- <version>3.4.0</version>
- </dependency>
-
- <!-- We no longer align the avro version with the version bundled in Hadoop.
- Users might need to downgrade the avro version for a particular Hadoop version. -->
- <dependency>
- <groupId>org.apache.avro</groupId>
- <artifactId>avro</artifactId>
- <version>${avro.version}</version>
- </dependency>
-
<!-- For dependency convergence -->
<dependency>
Review Comment:
Yes, I'll fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] fapaul commented on a diff in pull request #15: [FLINK-27475][Build] Clean-up unused Maven dependencies, plugins and profiles
Posted by GitBox <gi...@apache.org>.
fapaul commented on code in PR #15:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/15#discussion_r863795387
##########
pom.xml:
##########
@@ -806,32 +436,6 @@ under the License.
<artifactId>maven-shade-plugin</artifactId>
<version>3.2.4</version>
</plugin>
- <plugin>
- <groupId>com.github.siom79.japicmp</groupId>
- <artifactId>japicmp-maven-plugin</artifactId>
Review Comment:
Did you remove the japicmp plugin intentionally?
##########
pom.xml:
##########
@@ -393,67 +338,13 @@ under the License.
<version>3.3.2</version>
</dependency>
- <dependency>
- <groupId>org.xerial.snappy</groupId>
- <artifactId>snappy-java</artifactId>
- <version>1.1.8.3</version>
- </dependency>
-
- <dependency>
- <groupId>org.lz4</groupId>
- <artifactId>lz4-java</artifactId>
- <version>${lz4.version}</version>
- </dependency>
-
- <dependency>
- <groupId>com.github.oshi</groupId>
- <artifactId>oshi-core</artifactId>
- <version>3.4.0</version>
- </dependency>
-
- <!-- We no longer align the avro version with the version bundled in Hadoop.
- Users might need to downgrade the avro version for a particular Hadoop version. -->
- <dependency>
- <groupId>org.apache.avro</groupId>
- <artifactId>avro</artifactId>
- <version>${avro.version}</version>
- </dependency>
-
<!-- For dependency convergence -->
<dependency>
Review Comment:
Nit: Do we still need hamcrest? I hoped all assertions are migrated to assertJ by now.
##########
pom.xml:
##########
@@ -1556,78 +1000,6 @@ under the License.
</rules>
</configuration>
</execution>
- <execution>
- <id>ban-unsafe-snakeyaml</id>
- <goals>
Review Comment:
Did you verify that the connector does not use jackson, snakeyaml or uses versions that are not vulnerable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] MartijnVisser commented on pull request #15: [FLINK-27475][Build] Clean-up unused Maven dependencies, plugins and profiles
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #15:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/15#issuecomment-1123826501
@zentol Can you have one more look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] zentol commented on a diff in pull request #15: [FLINK-27475][Build] Clean-up unused Maven dependencies, plugins and profiles
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #15:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/15#discussion_r873489423
##########
pom.xml:
##########
@@ -1556,78 +1000,6 @@ under the License.
</rules>
</configuration>
</execution>
- <execution>
- <id>ban-unsafe-snakeyaml</id>
- <goals>
Review Comment:
I think these are less important for connectors because the project is much more focused, with a relatively small dependency tree that also doesn't change a lot structurally.
The dependency tree of Flink is massive, so such safeguards make more sense there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] MartijnVisser commented on a diff in pull request #15: [FLINK-27475][Build] Clean-up unused Maven dependencies, plugins and profiles
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on code in PR #15:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/15#discussion_r864791619
##########
flink-connector-elasticsearch7/pom.xml:
##########
@@ -81,20 +81,6 @@ under the License.
<groupId>org.elasticsearch.client</groupId>
<artifactId>elasticsearch-rest-high-level-client</artifactId>
<version>${elasticsearch.version}</version>
- <!-- elasticsearch-rest-client includes two different versions of httpcore-nio -->
- <exclusions>
- <exclusion>
- <groupId>org.apache.httpcomponents</groupId>
- <artifactId>httpcore-nio</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
-
- <!-- We need to include httpcore-nio again in the correct version due to the exclusion above -->
- <dependency>
Review Comment:
Thanks. I'll also add that to the pipeline, that must be there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] alpreu commented on a diff in pull request #15: [FLINK-27475][Build] Clean-up unused Maven dependencies, plugins and profiles
Posted by GitBox <gi...@apache.org>.
alpreu commented on code in PR #15:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/15#discussion_r871260915
##########
pom.xml:
##########
@@ -393,67 +338,13 @@ under the License.
<version>3.3.2</version>
</dependency>
- <dependency>
- <groupId>org.xerial.snappy</groupId>
- <artifactId>snappy-java</artifactId>
- <version>1.1.8.3</version>
- </dependency>
-
- <dependency>
- <groupId>org.lz4</groupId>
- <artifactId>lz4-java</artifactId>
- <version>${lz4.version}</version>
- </dependency>
-
- <dependency>
- <groupId>com.github.oshi</groupId>
- <artifactId>oshi-core</artifactId>
- <version>3.4.0</version>
- </dependency>
-
- <!-- We no longer align the avro version with the version bundled in Hadoop.
- Users might need to downgrade the avro version for a particular Hadoop version. -->
- <dependency>
- <groupId>org.apache.avro</groupId>
- <artifactId>avro</artifactId>
- <version>${avro.version}</version>
- </dependency>
-
<!-- For dependency convergence -->
<dependency>
Review Comment:
https://github.com/apache/flink-connector-elasticsearch/pull/17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] MartijnVisser merged pull request #15: [FLINK-27475][Build] Clean-up unused Maven dependencies, plugins and profiles
Posted by GitBox <gi...@apache.org>.
MartijnVisser merged PR #15:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] MartijnVisser commented on a diff in pull request #15: [FLINK-27475][Build] Clean-up unused Maven dependencies, plugins and profiles
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on code in PR #15:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/15#discussion_r864778551
##########
pom.xml:
##########
@@ -393,67 +338,13 @@ under the License.
<version>3.3.2</version>
</dependency>
- <dependency>
- <groupId>org.xerial.snappy</groupId>
- <artifactId>snappy-java</artifactId>
- <version>1.1.8.3</version>
- </dependency>
-
- <dependency>
- <groupId>org.lz4</groupId>
- <artifactId>lz4-java</artifactId>
- <version>${lz4.version}</version>
- </dependency>
-
- <dependency>
- <groupId>com.github.oshi</groupId>
- <artifactId>oshi-core</artifactId>
- <version>3.4.0</version>
- </dependency>
-
- <!-- We no longer align the avro version with the version bundled in Hadoop.
- Users might need to downgrade the avro version for a particular Hadoop version. -->
- <dependency>
- <groupId>org.apache.avro</groupId>
- <artifactId>avro</artifactId>
- <version>${avro.version}</version>
- </dependency>
-
<!-- For dependency convergence -->
<dependency>
Review Comment:
I still see Hamcrest being used in the Java code unfortunately...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] MartijnVisser commented on a diff in pull request #15: [FLINK-27475][Build] Clean-up unused Maven dependencies, plugins and profiles
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on code in PR #15:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/15#discussion_r864797545
##########
pom.xml:
##########
@@ -1556,78 +1000,6 @@ under the License.
</rules>
</configuration>
</execution>
- <execution>
- <id>ban-unsafe-snakeyaml</id>
- <goals>
Review Comment:
I haven't. Been I'm also wondering if that still makes sense for an external connector: there are more dependencies of course that could be vulnerable, why specifically target these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] MartijnVisser commented on a diff in pull request #15: [FLINK-27475][Build] Clean-up unused Maven dependencies, plugins and profiles
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on code in PR #15:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/15#discussion_r871416326
##########
pom.xml:
##########
@@ -393,67 +338,13 @@ under the License.
<version>3.3.2</version>
</dependency>
- <dependency>
- <groupId>org.xerial.snappy</groupId>
- <artifactId>snappy-java</artifactId>
- <version>1.1.8.3</version>
- </dependency>
-
- <dependency>
- <groupId>org.lz4</groupId>
- <artifactId>lz4-java</artifactId>
- <version>${lz4.version}</version>
- </dependency>
-
- <dependency>
- <groupId>com.github.oshi</groupId>
- <artifactId>oshi-core</artifactId>
- <version>3.4.0</version>
- </dependency>
-
- <!-- We no longer align the avro version with the version bundled in Hadoop.
- Users might need to downgrade the avro version for a particular Hadoop version. -->
- <dependency>
- <groupId>org.apache.avro</groupId>
- <artifactId>avro</artifactId>
- <version>${avro.version}</version>
- </dependency>
-
<!-- For dependency convergence -->
<dependency>
Review Comment:
Resolved
##########
flink-connector-elasticsearch7/pom.xml:
##########
@@ -81,20 +81,6 @@ under the License.
<groupId>org.elasticsearch.client</groupId>
<artifactId>elasticsearch-rest-high-level-client</artifactId>
<version>${elasticsearch.version}</version>
- <!-- elasticsearch-rest-client includes two different versions of httpcore-nio -->
- <exclusions>
- <exclusion>
- <groupId>org.apache.httpcomponents</groupId>
- <artifactId>httpcore-nio</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
-
- <!-- We need to include httpcore-nio again in the correct version due to the exclusion above -->
- <dependency>
Review Comment:
Resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] MartijnVisser commented on a diff in pull request #15: [FLINK-27475][Build] Clean-up unused Maven dependencies, plugins and profiles
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on code in PR #15:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/15#discussion_r870598818
##########
flink-connector-elasticsearch7/pom.xml:
##########
@@ -81,20 +81,6 @@ under the License.
<groupId>org.elasticsearch.client</groupId>
<artifactId>elasticsearch-rest-high-level-client</artifactId>
<version>${elasticsearch.version}</version>
- <!-- elasticsearch-rest-client includes two different versions of httpcore-nio -->
- <exclusions>
- <exclusion>
- <groupId>org.apache.httpcomponents</groupId>
- <artifactId>httpcore-nio</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
-
- <!-- We need to include httpcore-nio again in the correct version due to the exclusion above -->
- <dependency>
Review Comment:
@afedulov FYI https://github.com/apache/flink-connector-elasticsearch/pull/16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] MartijnVisser commented on a diff in pull request #15: [FLINK-27475][Build] Clean-up unused Maven dependencies, plugins and profiles
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on code in PR #15:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/15#discussion_r873514002
##########
pom.xml:
##########
@@ -576,100 +378,25 @@ under the License.
<version>2.24.0</version>
</dependency>
+ <!-- For dependency convergence -->
<dependency>
- <groupId>org.scala-lang</groupId>
- <artifactId>scala-library</artifactId>
- <version>${scala.version}</version>
+ <groupId>org.objenesis</groupId>
+ <artifactId>objenesis</artifactId>
+ <version>2.1</version>
</dependency>
<dependency>
<groupId>org.scala-lang</groupId>
- <artifactId>scala-reflect</artifactId>
+ <artifactId>scala-compiler</artifactId>
Review Comment:
Only as a test dependency:
```
[INFO] +- org.apache.flink:flink-table-planner_2.12:jar:1.16-SNAPSHOT:test
[INFO] | +- org.codehaus.janino:commons-compiler:jar:3.0.11:test
[INFO] | +- org.codehaus.janino:janino:jar:3.0.11:test
[INFO] | +- org.apache.flink:flink-scala_2.12:jar:1.16-SNAPSHOT:test
[INFO] | | +- org.scala-lang:scala-reflect:jar:2.12.7:test
[INFO] | | +- org.scala-lang:scala-library:jar:2.12.7:test
[INFO] | | +- org.scala-lang:scala-compiler:jar:2.12.7:test
[INFO] | | | \- org.scala-lang.modules:scala-xml_2.12:jar:1.0.6:test
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] MartijnVisser commented on a diff in pull request #15: [FLINK-27475][Build] Clean-up unused Maven dependencies, plugins and profiles
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on code in PR #15:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/15#discussion_r864795862
##########
pom.xml:
##########
@@ -1945,122 +1311,6 @@ under the License.
</executions>
</plugin>
- <!-- configure scala style -->
- <plugin>
- <groupId>org.scalastyle</groupId>
- <artifactId>scalastyle-maven-plugin</artifactId>
- <version>1.0.0</version>
- <executions>
- <execution>
- <phase>validate</phase>
- <goals>
- <goal>check</goal>
- </goals>
- </execution>
- </executions>
- <configuration>
- <verbose>false</verbose>
- <failOnViolation>true</failOnViolation>
- <includeTestSourceDirectory>true</includeTestSourceDirectory>
- <failOnWarning>false</failOnWarning>
- <sourceDirectory>${basedir}/src/main/scala</sourceDirectory>
- <testSourceDirectory>${basedir}/src/test/scala</testSourceDirectory>
- <outputFile>${project.basedir}/target/scalastyle-output.xml</outputFile>
- <inputEncoding>UTF-8</inputEncoding>
- <outputEncoding>UTF-8</outputEncoding>
- </configuration>
- </plugin>
-
- <!-- set scala maven plugin version -->
- <plugin>
- <groupId>net.alchim31.maven</groupId>
- <artifactId>scala-maven-plugin</artifactId>
- <version>3.2.2</version>
- <configuration>
- <args>
- <arg>-nobootcp</arg>
- <arg>-target:jvm-${target.java.version}</arg>
- </args>
- <jvmArgs>
- <arg>-Xss2m</arg>
- </jvmArgs>
- </configuration>
- </plugin>
-
- <!-- Configuration for the binary compatibility checker -->
- <plugin>
- <groupId>com.github.siom79.japicmp</groupId>
- <artifactId>japicmp-maven-plugin</artifactId>
Review Comment:
Restored
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] zentol commented on a diff in pull request #15: [FLINK-27475][Build] Clean-up unused Maven dependencies, plugins and profiles
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #15:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/15#discussion_r864533814
##########
pom.xml:
##########
@@ -1314,132 +862,30 @@ under the License.
<exclude>docs/static/font-awesome/**</exclude>
<exclude>docs/static/flink-header-logo.svg</exclude>
<exclude>docs/static/figs/*.svg</exclude>
Review Comment:
```suggestion
```
##########
pom.xml:
##########
@@ -1314,132 +862,30 @@ under the License.
<exclude>docs/static/font-awesome/**</exclude>
<exclude>docs/static/flink-header-logo.svg</exclude>
<exclude>docs/static/figs/*.svg</exclude>
- <exclude>flink-clients/src/main/resources/web-docs/js/*d3.js</exclude>
<!-- the licenses that are re-bundled -->
<exclude>**/packaged_licenses/LICENSE.*.txt</exclude>
<exclude>**/licenses/LICENSE*</exclude>
<exclude>**/licenses-binary/LICENSE*</exclude>
Review Comment:
```suggestion
```
##########
pom.xml:
##########
@@ -1083,55 +680,6 @@ under the License.
</build>
</profile>
- <profile>
- <!-- Kept for backwards compatiblity, the doc buildbot expects
- this profile to exist.-->
- <id>aggregate-scaladoc</id>
- </profile>
-
-
- <profile>
- <!-- used for SNAPSHOT and regular releases -->
- <id>docs-and-source</id>
Review Comment:
Do not intend to publish javadocs? (And if so, how shall we integrate them into the docs?)
##########
pom.xml:
##########
@@ -1314,132 +862,30 @@ under the License.
<exclude>docs/static/font-awesome/**</exclude>
<exclude>docs/static/flink-header-logo.svg</exclude>
<exclude>docs/static/figs/*.svg</exclude>
- <exclude>flink-clients/src/main/resources/web-docs/js/*d3.js</exclude>
<!-- the licenses that are re-bundled -->
<exclude>**/packaged_licenses/LICENSE.*.txt</exclude>
<exclude>**/licenses/LICENSE*</exclude>
<exclude>**/licenses-binary/LICENSE*</exclude>
- <!-- web dashboard config JSON files -->
- <exclude>flink-runtime-web/web-dashboard/package.json</exclude>
- <exclude>flink-runtime-web/web-dashboard/package-lock.json</exclude>
- <exclude>flink-runtime-web/web-dashboard/angular.json</exclude>
- <exclude>flink-runtime-web/web-dashboard/proxy.conf.json</exclude>
- <exclude>flink-runtime-web/web-dashboard/tsconfig.json</exclude>
- <exclude>flink-runtime-web/web-dashboard/tslint.json</exclude>
- <exclude>flink-runtime-web/web-dashboard/src/browserslist</exclude>
- <exclude>flink-runtime-web/web-dashboard/src/tsconfig.app.json</exclude>
- <exclude>flink-runtime-web/web-dashboard/src/tsconfig.spec.json</exclude>
- <exclude>flink-runtime-web/web-dashboard/src/tslint.json</exclude>
-
- <!-- web dashboard non-binary assets -->
- <exclude>flink-runtime-web/web-dashboard/src/assets/**</exclude>
-
- <!-- generated contents -->
- <exclude>flink-runtime-web/web-dashboard/web/**</exclude>
-
- <!-- downloaded and generated web libraries. -->
- <exclude>flink-runtime-web/web-dashboard/node_modules/**</exclude>
- <exclude>flink-runtime-web/web-dashboard/node/**</exclude>
-
- <!-- antlr grammar files -->
- <exclude>flink-table/flink-table-code-splitter/src/main/antlr4/**</exclude>
-
<!-- Test Data. -->
<exclude>**/src/test/resources/*-data</exclude>
- <exclude>flink-tests/src/test/resources/testdata/terainput.txt</exclude>
- <exclude>flink-formats/flink-avro/src/test/resources/flink_11-kryo_registrations</exclude>
- <exclude>flink-scala/src/test/resources/flink_11-kryo_registrations</exclude>
- <exclude>flink-core/src/test/resources/kryo-serializer-config-snapshot-v1</exclude>
- <exclude>flink-formats/flink-avro/src/test/resources/avro/*.avsc</exclude>
<exclude>out/test/flink-avro/avro/user.avsc</exclude>
- <exclude>flink-table/flink-sql-client/src/test/resources/*.out</exclude>
- <exclude>flink-table/flink-table-planner/src/test/resources/**/*.out</exclude>
- <exclude>flink-table/flink-table-planner/src/test/resources/json/*.json</exclude>
- <exclude>flink-yarn/src/test/resources/krb5.keytab</exclude>
- <exclude>flink-end-to-end-tests/test-scripts/test-data/**</exclude>
- <exclude>flink-end-to-end-tests/test-scripts/docker-hadoop-secure-cluster/config/keystore.jks</exclude>
- <exclude>flink-connectors/flink-connector-kafka/src/test/resources/**</exclude>
- <exclude>flink-connectors/flink-connector-hive/src/test/resources/**</exclude>
- <exclude>flink-end-to-end-tests/flink-tpcds-test/tpcds-tool/answer_set/*</exclude>
- <exclude>flink-end-to-end-tests/flink-tpcds-test/tpcds-tool/query/*</exclude>
- <exclude>flink-connectors/flink-connector-aws-base/src/test/resources/profile</exclude>
- <exclude>flink-connectors/flink-connector-kinesis/src/test/resources/profile</exclude>
- <exclude>flink-connectors/flink-connector-aws-kinesis-streams/src/test/resources/profile</exclude>
- <exclude>flink-table/flink-table-code-splitter/src/test/resources/**</exclude>
- <exclude>flink-connectors/flink-connector-pulsar/src/test/resources/**</exclude>
<!-- ArchUnit violation stores -->
<exclude>**/archunit-violations/**</exclude>
- <!-- snapshots -->
- <exclude>**/src/test/resources/serializer-snapshot-*</exclude>
- <exclude>**/src/test/resources/**/serializer-snapshot</exclude>
- <exclude>**/src/test/resources/**/test-data</exclude>
- <exclude>**/src/test/resources/*-snapshot</exclude>
- <exclude>**/src/test/resources/*.snapshot</exclude>
- <exclude>**/src/test/resources/*-savepoint/**</exclude>
- <exclude>**/src/test/resources/*-savepoint-native/**</exclude>
- <exclude>**/src/test/resources/*-checkpoint/**</exclude>
- <exclude>flink-core/src/test/resources/serialized-kryo-serializer-1.3</exclude>
- <exclude>flink-core/src/test/resources/type-without-avro-serialized-using-kryo</exclude>
- <exclude>flink-formats/flink-avro/src/test/resources/flink-1.4-serializer-java-serialized</exclude>
-
- <exclude>flink-end-to-end-tests/flink-state-evolution-test/src/main/java/org/apache/flink/avro/generated/*</exclude>
- <exclude>flink-end-to-end-tests/flink-state-evolution-test/savepoints/*</exclude>
- <exclude>flink-formats/flink-avro/src/test/resources/testdata.avro</exclude>
- <exclude>flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/generated/*.java</exclude>
- <exclude>flink-formats/flink-avro-confluent-registry/src/test/resources/*.json</exclude>
- <exclude>flink-formats/flink-avro-confluent-registry/src/test/resources/*.avro</exclude>
- <exclude>flink-formats/flink-json/src/test/resources/*.txt</exclude>
- <exclude>flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/generated/*.java</exclude>
- <exclude>flink-formats/flink-parquet/src/test/resources/avro/**</exclude>
- <exclude>flink-formats/flink-parquet/src/test/resources/protobuf/**</exclude>
- <!-- netty test file, still Apache License 2.0 but with a different header -->
- <exclude>flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/AbstractByteBufTest.java</exclude>
- <!-- Configuration Files. -->
- <exclude>**/flink-bin/conf/workers</exclude>
- <exclude>**/flink-bin/conf/masters</exclude>
<!-- Administrative files in the main trunk. -->
<exclude>**/README.md</exclude>
<exclude>.github/**</exclude>
<!-- Build files -->
<exclude>**/*.iml</exclude>
- <exclude>flink-quickstart/**/testArtifact/goal.txt</exclude>
<!-- Generated content -->
<exclude>out/**</exclude>
<exclude>**/target/**</exclude>
<exclude>**/scalastyle-output.xml</exclude>
Review Comment:
```suggestion
```
##########
pom.xml:
##########
@@ -1314,132 +862,30 @@ under the License.
<exclude>docs/static/font-awesome/**</exclude>
<exclude>docs/static/flink-header-logo.svg</exclude>
<exclude>docs/static/figs/*.svg</exclude>
Review Comment:
there are more above that can also be removed.
##########
pom.xml:
##########
@@ -1945,122 +1311,6 @@ under the License.
</executions>
</plugin>
- <!-- configure scala style -->
- <plugin>
- <groupId>org.scalastyle</groupId>
- <artifactId>scalastyle-maven-plugin</artifactId>
- <version>1.0.0</version>
- <executions>
- <execution>
- <phase>validate</phase>
- <goals>
- <goal>check</goal>
- </goals>
- </execution>
- </executions>
- <configuration>
- <verbose>false</verbose>
- <failOnViolation>true</failOnViolation>
- <includeTestSourceDirectory>true</includeTestSourceDirectory>
- <failOnWarning>false</failOnWarning>
- <sourceDirectory>${basedir}/src/main/scala</sourceDirectory>
- <testSourceDirectory>${basedir}/src/test/scala</testSourceDirectory>
- <outputFile>${project.basedir}/target/scalastyle-output.xml</outputFile>
- <inputEncoding>UTF-8</inputEncoding>
- <outputEncoding>UTF-8</outputEncoding>
- </configuration>
- </plugin>
-
- <!-- set scala maven plugin version -->
- <plugin>
- <groupId>net.alchim31.maven</groupId>
- <artifactId>scala-maven-plugin</artifactId>
- <version>3.2.2</version>
- <configuration>
- <args>
- <arg>-nobootcp</arg>
- <arg>-target:jvm-${target.java.version}</arg>
- </args>
- <jvmArgs>
- <arg>-Xss2m</arg>
- </jvmArgs>
- </configuration>
- </plugin>
-
- <!-- Configuration for the binary compatibility checker -->
- <plugin>
- <groupId>com.github.siom79.japicmp</groupId>
- <artifactId>japicmp-maven-plugin</artifactId>
Review Comment:
a bit strange that this is removed.
##########
pom.xml:
##########
@@ -1945,122 +1311,6 @@ under the License.
</executions>
</plugin>
- <!-- configure scala style -->
- <plugin>
- <groupId>org.scalastyle</groupId>
- <artifactId>scalastyle-maven-plugin</artifactId>
- <version>1.0.0</version>
- <executions>
- <execution>
- <phase>validate</phase>
- <goals>
- <goal>check</goal>
- </goals>
- </execution>
- </executions>
- <configuration>
- <verbose>false</verbose>
- <failOnViolation>true</failOnViolation>
- <includeTestSourceDirectory>true</includeTestSourceDirectory>
- <failOnWarning>false</failOnWarning>
- <sourceDirectory>${basedir}/src/main/scala</sourceDirectory>
- <testSourceDirectory>${basedir}/src/test/scala</testSourceDirectory>
- <outputFile>${project.basedir}/target/scalastyle-output.xml</outputFile>
- <inputEncoding>UTF-8</inputEncoding>
- <outputEncoding>UTF-8</outputEncoding>
- </configuration>
- </plugin>
-
- <!-- set scala maven plugin version -->
- <plugin>
- <groupId>net.alchim31.maven</groupId>
- <artifactId>scala-maven-plugin</artifactId>
- <version>3.2.2</version>
- <configuration>
- <args>
- <arg>-nobootcp</arg>
- <arg>-target:jvm-${target.java.version}</arg>
- </args>
- <jvmArgs>
- <arg>-Xss2m</arg>
- </jvmArgs>
- </configuration>
- </plugin>
-
- <!-- Configuration for the binary compatibility checker -->
- <plugin>
- <groupId>com.github.siom79.japicmp</groupId>
- <artifactId>japicmp-maven-plugin</artifactId>
- <version>0.11.0</version>
- <configuration>
- <oldVersion>
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>${project.artifactId}</artifactId>
- <version>${japicmp.referenceVersion}</version>
- <type>${project.packaging}</type>
- </dependency>
- </oldVersion>
- <newVersion>
- <file>
- <path>${project.build.directory}/${project.artifactId}-${project.version}.${project.packaging}</path>
- </file>
- </newVersion>
- <parameter>
- <onlyModified>true</onlyModified>
- <includes>
- <include>@org.apache.flink.annotation.Public</include>
- <!-- The following line is un-commented by tools/releasing/update_japicmp_configuration.sh
- as part of the release process -->
- <!--<include>@org.apache.flink.annotation.PublicEvolving</include>-->
- </includes>
- <excludes>
- <exclude>@org.apache.flink.annotation.Experimental</exclude>
- <exclude>@org.apache.flink.annotation.PublicEvolving</exclude>
- <exclude>@org.apache.flink.annotation.Internal</exclude>
- <exclude>org.apache.flink.streaming.api.datastream.DataStream#DataStream(org.apache.flink.streaming.api.environment.StreamExecutionEnvironment,org.apache.flink.streaming.api.transformations.StreamTransformation)</exclude>
- <exclude>org.apache.flink.streaming.api.environment.LegacyLocalStreamEnvironment</exclude>
- <exclude>org.apache.flink.streaming.api.functions.sink.RichSinkFunction#invoke(java.lang.Object)</exclude>
- <exclude>org.apache.flink.streaming.api.functions.sink.SinkFunction</exclude>
- <exclude>org.apache.flink.api.java.hadoop.mapred.HadoopInputFormat</exclude>
- <exclude>org.apache.flink.api.java.hadoop.mapred.HadoopOutputFormat</exclude>
- <exclude>org.apache.flink.api.java.hadoop.mapreduce.HadoopInputFormat</exclude>
- <exclude>org.apache.flink.api.java.hadoop.mapreduce.HadoopOutputFormat</exclude>
- <exclude>org.apache.flink.api.scala.hadoop.mapred.HadoopInputFormat</exclude>
- <exclude>org.apache.flink.api.scala.hadoop.mapred.HadoopOutputFormat</exclude>
- <exclude>org.apache.flink.api.scala.hadoop.mapreduce.HadoopInputFormat</exclude>
- <exclude>org.apache.flink.api.scala.hadoop.mapreduce.HadoopOutputFormat</exclude>
- </excludes>
- <accessModifier>public</accessModifier>
- <breakBuildOnModifications>false</breakBuildOnModifications>
- <breakBuildOnBinaryIncompatibleModifications>true</breakBuildOnBinaryIncompatibleModifications>
- <breakBuildOnSourceIncompatibleModifications>true</breakBuildOnSourceIncompatibleModifications>
- <onlyBinaryIncompatible>false</onlyBinaryIncompatible>
- <includeSynthetic>true</includeSynthetic>
- <ignoreMissingClasses>false</ignoreMissingClasses>
- <skipPomModules>true</skipPomModules>
- <!-- Don't break build on newly added maven modules -->
- <ignoreNonResolvableArtifacts>true</ignoreNonResolvableArtifacts>
- </parameter>
- <projectBuildDir>${rootDir}/${japicmp.outputDir}/${project.artifactId}</projectBuildDir>
- <dependencies>
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-annotations</artifactId>
- <version>${project.version}</version>
- </dependency>
- </dependencies>
- </configuration>
- <executions>
- <execution>
- <phase>verify</phase>
- <goals>
- <goal>cmp</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
-
<plugin>
<!-- run via "mvn org.owasp:dependency-check-maven:aggregate" -->
<groupId>org.owasp</groupId>
Review Comment:
this can also be removed; no one is using it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] MartijnVisser commented on a diff in pull request #15: [FLINK-27475][Build] Clean-up unused Maven dependencies, plugins and profiles
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on code in PR #15:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/15#discussion_r864794234
##########
pom.xml:
##########
@@ -806,32 +436,6 @@ under the License.
<artifactId>maven-shade-plugin</artifactId>
<version>3.2.4</version>
</plugin>
- <plugin>
- <groupId>com.github.siom79.japicmp</groupId>
- <artifactId>japicmp-maven-plugin</artifactId>
Review Comment:
Yes but now restoring it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] MartijnVisser commented on a diff in pull request #15: [FLINK-27475][Build] Clean-up unused Maven dependencies, plugins and profiles
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on code in PR #15:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/15#discussion_r870598592
##########
pom.xml:
##########
@@ -393,67 +338,13 @@ under the License.
<version>3.3.2</version>
</dependency>
- <dependency>
- <groupId>org.xerial.snappy</groupId>
- <artifactId>snappy-java</artifactId>
- <version>1.1.8.3</version>
- </dependency>
-
- <dependency>
- <groupId>org.lz4</groupId>
- <artifactId>lz4-java</artifactId>
- <version>${lz4.version}</version>
- </dependency>
-
- <dependency>
- <groupId>com.github.oshi</groupId>
- <artifactId>oshi-core</artifactId>
- <version>3.4.0</version>
- </dependency>
-
- <!-- We no longer align the avro version with the version bundled in Hadoop.
- Users might need to downgrade the avro version for a particular Hadoop version. -->
- <dependency>
- <groupId>org.apache.avro</groupId>
- <artifactId>avro</artifactId>
- <version>${avro.version}</version>
- </dependency>
-
<!-- For dependency convergence -->
<dependency>
Review Comment:
@alpreu Do you know if we could fix this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-elasticsearch] zentol commented on a diff in pull request #15: [FLINK-27475][Build] Clean-up unused Maven dependencies, plugins and profiles
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #15:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/15#discussion_r873489423
##########
pom.xml:
##########
@@ -1556,78 +1000,6 @@ under the License.
</rules>
</configuration>
</execution>
- <execution>
- <id>ban-unsafe-snakeyaml</id>
- <goals>
Review Comment:
I think these are less important for connectors because the project is much more focused, with a relatively small dependency tree that also doesn't change a lot.
The dependency tree of Flink is massive, so such safeguards make more sense there.
##########
pom.xml:
##########
@@ -576,100 +378,25 @@ under the License.
<version>2.24.0</version>
</dependency>
+ <!-- For dependency convergence -->
<dependency>
- <groupId>org.scala-lang</groupId>
- <artifactId>scala-library</artifactId>
- <version>${scala.version}</version>
+ <groupId>org.objenesis</groupId>
+ <artifactId>objenesis</artifactId>
+ <version>2.1</version>
</dependency>
<dependency>
<groupId>org.scala-lang</groupId>
- <artifactId>scala-reflect</artifactId>
+ <artifactId>scala-compiler</artifactId>
Review Comment:
does scala actually end up anywhere in the dependency tree? I think that shouldn't be the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org