[GitHub] merlimat opened a new pull request #1280: Removing references for "destination" names

[GitBox <gi...@apache.org>]

merlimat opened a new pull request #1280: Removing references for "destination" names
URL: https://github.com/apache/incubator-pulsar/pull/1280
 
 
   ### Motivation
   
   The usage of the term "destination" has a long legacy root in Pulsar. Destination term is used in JMS specification to identify either a "topic" or a "queue". 
   
   In Pulsar we only have "topics", though they can also provide the same semantics as JMS queue, so we don't need to have a generic term.
   
   So far, we've been liberally using either "topic" or "destination" indifferently in the code base to mean the same exact thing. This can be confusing to many people and there's no need to continue with that.
   
   There should only be 1 way to call a topic.
   
   ### Modifications
   
    * Renamed `DestinationName` class into `TopicName`
    * Renamed `DestinationDomain` into `TopicDomain` (either `persistent` or `non-persistent`)
    * Renamed all variables mentioning "destination" into `topic` or `topicName`
    * Adjusted Javadocs to always refer to topics
   
   Not modified: 
    * `/admin/namespaces/destinations` in v1 admin API to keep compatibility
    * Website documentation: will address that later
   
   ### Result
   
   Simplified nomenclature and avoid exposing undocumented concepts like "destination".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services