[GitHub] [airflow] turbaszek commented on a change in pull request #8849: Add multiple file upload functionality to GCS hook

[GitBox <gi...@apache.org>]

turbaszek commented on a change in pull request #8849:
URL: https://github.com/apache/airflow/pull/8849#discussion_r424918931



##########
File path: tests/providers/google/cloud/operators/test_local_to_gcs.py
##########
@@ -42,6 +67,10 @@ def setUp(self):
             'start_date': datetime.datetime(2017, 1, 1)
         }
         self.dag = DAG('test_dag_id', default_args=args)
+        with open('/tmp/fake1.csv', 'wb') as f:
+            f.write(b"x" * 393216)
+        with open('/tmp/fake2.csv', 'wb') as f:
+            f.write(b"x" * 393216)

Review comment:
       This files are not delted, thus this test creates side effects. Please use temp files or mocking. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org