You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "hongkunxu (via GitHub)" <gi...@apache.org> on 2025/08/09 15:37:42 UTC
[PR] [Feature] Support extracting geo info from ip [pinot]
hongkunxu opened a new pull request, #16564:
URL: https://github.com/apache/pinot/pull/16564
This PR aim to support extract geo info (country/asn etc) from ip address.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [Feature] Support extracting geo info from ip [pinot]
Posted by "dinoocch (via GitHub)" <gi...@apache.org>.
dinoocch commented on code in PR #16564:
URL: https://github.com/apache/pinot/pull/16564#discussion_r2274887663
##########
pinot-common/src/main/resources/GeoLite2-ASN.mmdb:
##########
Review Comment:
Same question here -- can we really check in geolite db's? Should we?
##########
pinot-common/pom.xml:
##########
@@ -270,6 +286,11 @@
<groupId>com.google.auto.service</groupId>
<artifactId>auto-service-annotations</artifactId>
</dependency>
+ <dependency>
+ <groupId>com.maxmind.geoip2</groupId>
+ <artifactId>geoip2</artifactId>
+ <version>4.0.1</version>
Review Comment:
I was vaguely under the impression that maxmind needed a license for commercial use of their geo ip dbs, is that not true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [Feature] Support extracting geo info from ip [pinot]
Posted by "hongkunxu (via GitHub)" <gi...@apache.org>.
hongkunxu closed pull request #16564: [Feature] Support extracting geo info from ip
URL: https://github.com/apache/pinot/pull/16564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org