[GitHub] [netbeans] jlahoda commented on a change in pull request #1244: [NETBEANS-1936] Usage of remainderDelimiter

[GitBox <gi...@apache.org>]

jlahoda commented on a change in pull request #1244: [NETBEANS-1936] Usage of remainderDelimiter
URL: https://github.com/apache/netbeans/pull/1244#discussion_r283119343
 
 

 ##########
 File path: ide/subversion/src/org/netbeans/modules/subversion/client/cli/commands/VersionCommand.java
 ##########
 @@ -84,7 +84,7 @@ public boolean checkForErrors() {
             if (pos > -1) {
                 String vString = string.substring(pos + 9);
                 Subversion.LOG.log(Level.INFO, "Commandline client version: {0}", vString);
-                Version version = Version.parse(vString.replace("-dev", ""));
+                Version version = Version.parse(vString, "-");
 
 Review comment:
   So, I am not an expert on svn versioning, but my svn client says:
   > svn, version 1.9.7 (r1800392)
   
   Looking at the code, the original code was able to parse that ("Version.parse(String)" automatically strips the second part after the space), but does the new version handle this? (And, is there time to introduce a test for this method?)
   
   Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists