You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by vy...@apache.org on 2023/10/31 11:53:00 UTC
(logging-log4j2) 01/02: Add missing `Implementation-` and `Specification-` entries to `MANIFEST.MF` (#1923)
This is an automated email from the ASF dual-hosted git repository.
vy pushed a commit to branch 2.x
in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git
commit 40e59eb2225d6c9330bfa3db92617738dbc594e7
Author: Volkan Yazıcı <vo...@yazi.ci>
AuthorDate: Tue Oct 31 12:51:40 2023 +0100
Add missing `Implementation-` and `Specification-` entries to `MANIFEST.MF` (#1923)
---
pom.xml | 20 ++++++++++++++++++++
src/changelog/.2.x.x/fix_manifest.xml | 8 ++++++++
src/site/_release-notes/_2.x.x.adoc | 2 +-
3 files changed, 29 insertions(+), 1 deletion(-)
diff --git a/pom.xml b/pom.xml
index 90d5e1522c..3357962950 100644
--- a/pom.xml
+++ b/pom.xml
@@ -306,6 +306,26 @@
<!-- project version -->
<revision>2.22.0-SNAPSHOT</revision>
+ <!-- ===================
+ `MANIFEST.MF` fixes
+ ===================
+
+ Adds certain `Implementation-*` and `Specification-*` entries to the generated `MANIFEST.MF`.
+ Using these properties is known to be a bad practice: https://github.com/apache/logging-log4j2/issues/1923#issuecomment-1786818254
+ Users should use `META-INF/maven/<groupId>/<artifactId>/pom.properties` instead.
+ Yet we support it due to backward compatibility reasons.
+ WARNING! These properties should ideally not be ported to Log4j 3!
+
+ Defining this as a property works.
+ Because `bnd-maven-plugin` automatically includes properties starting with a capital letter. -->
+ <Implementation-Title>${project.name}</Implementation-Title>
+ <Implementation-Vendor-Id>org.apache</Implementation-Vendor-Id>
+ <Implementation-Vendor>The Apache Software Foundation</Implementation-Vendor>
+ <Implementation-Version>${project.version}</Implementation-Version>
+ <Specification-Title>${project.name}</Specification-Title>
+ <Specification-Vendor>The Apache Software Foundation</Specification-Vendor>
+ <Specification-Version>${project.version}</Specification-Version>
+
<!-- =================
Common properties
================= -->
diff --git a/src/changelog/.2.x.x/fix_manifest.xml b/src/changelog/.2.x.x/fix_manifest.xml
new file mode 100644
index 0000000000..5067392a0b
--- /dev/null
+++ b/src/changelog/.2.x.x/fix_manifest.xml
@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<entry xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xmlns="http://logging.apache.org/log4j/changelog"
+ xsi:schemaLocation="http://logging.apache.org/log4j/changelog https://logging.apache.org/log4j/changelog-0.1.2.xsd"
+ type="fixed">
+ <issue id="1923" link="https://github.com/apache/logging-log4j2/issues/1923"/>
+ <description format="asciidoc">Add missing `Implementation-` and `Specification-` entries to `MANIFEST.MF`</description>
+</entry>
diff --git a/src/site/_release-notes/_2.x.x.adoc b/src/site/_release-notes/_2.x.x.adoc
index a0d30303f3..3d82503014 100644
--- a/src/site/_release-notes/_2.x.x.adoc
+++ b/src/site/_release-notes/_2.x.x.adoc
@@ -61,7 +61,6 @@ The module name of four bridges (`log4j-slf4j-impl`, `log4j-slf4j2-impl`, `log4j
* Update `org.fusesource.jansi:jansi` to version `2.4.1` (https://github.com/apache/logging-log4j2/pull/1907[1907])
* Update `org.mongodb:bson` to version `4.11.0` (https://github.com/apache/logging-log4j2/pull/1893[1893])
* Update `org.ow2.asm:asm-bom` to version `9.6` (https://github.com/apache/logging-log4j2/pull/1898[1898])
-* Update `org.slf4j:slf4j-ext` to version `2.0.9` (https://github.com/apache/logging-log4j2/pull/1929[1929])
* Update `org.springframework.boot:spring-boot` to version `2.7.17` (https://github.com/apache/logging-log4j2/pull/1874[1874])
* Update `org.zeromq:jeromq` to version `0.5.4` (https://github.com/apache/logging-log4j2/pull/1878[1878])
* Update `ossf/scorecard-action` to version `2.3.1` (https://github.com/apache/logging-log4j2/pull/1897[1897])
@@ -73,3 +72,4 @@ The module name of four bridges (`log4j-slf4j-impl`, `log4j-slf4j2-impl`, `log4j
* Export missing OSGi & JPMS modules in `log4j-layout-template-json` and `log4j-1.2-api` (https://github.com/apache/logging-log4j2/issues/1895[1895])
* Fix `spring-test` dependency scope change. (https://issues.apache.org/jira/browse/LOG4J2-3675[LOG4J2-3675])
* Fix JPMS descriptors causing `jlink` issues (https://github.com/apache/logging-log4j2/issues/1896[1896])
+* Add missing `Implementation-` and `Specification-` entries to `MANIFEST.MF` (https://github.com/apache/logging-log4j2/issues/1923[1923])