You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/04/15 14:41:41 UTC

[GitHub] [tvm] tristan-arm opened a new pull request #7858: [ETHOSN] Removed support for 20.08 version of the driver stack.

tristan-arm opened a new pull request #7858:
URL: https://github.com/apache/tvm/pull/7858


     - Replaced capabilities header file with api calls introduced by the 20.11 ethosn driver stack release.
     - Removed 20.08 driver stack support and updated all affected code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #7858: [ETHOSN] Removed support for 20.08 version of the driver stack.

Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #7858:
URL: https://github.com/apache/tvm/pull/7858#issuecomment-823469024


   cc @jroesch -- I think Jared is updating the images, but there is some challenge with GPU drivers right now that is blocking us.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] u99127 commented on pull request #7858: [ETHOSN] Removed support for 20.08 version of the driver stack.

Posted by GitBox <gi...@apache.org>.
u99127 commented on pull request #7858:
URL: https://github.com/apache/tvm/pull/7858#issuecomment-823909705


   @mbaret 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] mbaret commented on a change in pull request #7858: [ETHOSN] Removed support for 20.08 version of the driver stack.

Posted by GitBox <gi...@apache.org>.
mbaret commented on a change in pull request #7858:
URL: https://github.com/apache/tvm/pull/7858#discussion_r617692088



##########
File path: src/relay/backend/contrib/ethosn/codegen_ethosn.h
##########
@@ -240,18 +241,14 @@ struct EthosnCompilerConfigNode : public tvm::AttrsNode<EthosnCompilerConfigNode
   bool block_config_8x32;
   bool block_config_8x8;
   bool enable_intermediate_compression;
-#if _ETHOSN_API_VERSION_ == 2008
-  bool dump_debug_files;
-#endif
   bool disable_winograd;
   String debug_dir;
   String compiler_algorithm;
 
   TVM_DECLARE_ATTRS(EthosnCompilerConfigNode, "ext.attrs.EthosnCompilerConfigNode") {
-    TVM_ATTR_FIELD(variant)
-        .describe(
-            "0 for Ethos-N77, 1 for Ethos-N57, 2 for Ethos-N37,"
-            " 3 for Ethos-N78. See Ethos-N documentation.")
+    TVM_ATTR_FIELD(variant).describe("See Ethos-N documentation.").set_default("Ethos-N77");
+    TVM_ATTR_FIELD(sram_size_bytes)
+        .describe("Optionally override the default sram size. See Ethos-N documentation.")

Review comment:
       Is defaulting the sram size to 0 the correct thing to do?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] mbaret commented on pull request #7858: [ETHOSN] Removed support for 20.08 version of the driver stack.

Posted by GitBox <gi...@apache.org>.
mbaret commented on pull request #7858:
URL: https://github.com/apache/tvm/pull/7858#issuecomment-859527557


   This is now merged. Thanks @tristan-arm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] mbaret merged pull request #7858: [ETHOSN] Removed support for 20.08 version of the driver stack.

Posted by GitBox <gi...@apache.org>.
mbaret merged pull request #7858:
URL: https://github.com/apache/tvm/pull/7858


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #7858: [ETHOSN] Removed support for 20.08 version of the driver stack.

Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #7858:
URL: https://github.com/apache/tvm/pull/7858#issuecomment-830206736


   @jroesch what's the status of ci-cpu update?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tristan-arm commented on pull request #7858: [ETHOSN] Removed support for 20.08 version of the driver stack.

Posted by GitBox <gi...@apache.org>.
tristan-arm commented on pull request #7858:
URL: https://github.com/apache/tvm/pull/7858#issuecomment-823315754


   Test failure is due to the ci-cpu docker image using an outdated version of the ethos-n driver stack - should work fine if the docker image is recreated to account for changes to [ubuntu_install_ethosn_driver_stack.sh](https://github.com/apache/tvm/blob/main/docker/install/ubuntu_install_ethosn_driver_stack.sh)
   
   @areusch Can look into updating the ci-cpu docker image - Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tristan-arm commented on a change in pull request #7858: [ETHOSN] Removed support for 20.08 version of the driver stack.

Posted by GitBox <gi...@apache.org>.
tristan-arm commented on a change in pull request #7858:
URL: https://github.com/apache/tvm/pull/7858#discussion_r617699191



##########
File path: src/relay/backend/contrib/ethosn/codegen_ethosn.h
##########
@@ -240,18 +241,14 @@ struct EthosnCompilerConfigNode : public tvm::AttrsNode<EthosnCompilerConfigNode
   bool block_config_8x32;
   bool block_config_8x8;
   bool enable_intermediate_compression;
-#if _ETHOSN_API_VERSION_ == 2008
-  bool dump_debug_files;
-#endif
   bool disable_winograd;
   String debug_dir;
   String compiler_algorithm;
 
   TVM_DECLARE_ATTRS(EthosnCompilerConfigNode, "ext.attrs.EthosnCompilerConfigNode") {
-    TVM_ATTR_FIELD(variant)
-        .describe(
-            "0 for Ethos-N77, 1 for Ethos-N57, 2 for Ethos-N37,"
-            " 3 for Ethos-N78. See Ethos-N documentation.")
+    TVM_ATTR_FIELD(variant).describe("See Ethos-N documentation.").set_default("Ethos-N77");
+    TVM_ATTR_FIELD(sram_size_bytes)
+        .describe("Optionally override the default sram size. See Ethos-N documentation.")

Review comment:
       Yes, zero is used by the ethos-n driver stack to indicate that the default sram size is not to be overridden.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tristan-arm commented on pull request #7858: [ETHOSN] Removed support for 20.08 version of the driver stack.

Posted by GitBox <gi...@apache.org>.
tristan-arm commented on pull request #7858:
URL: https://github.com/apache/tvm/pull/7858#issuecomment-859391708


   > LGTM, but @tristan-arm could you confirm this has been tested against upstream CI post the container update before I merge?
   
   Sure, I've rebased and the tests are now green against the latest container updates.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #7858: [ETHOSN] Removed support for 20.08 version of the driver stack.

Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #7858:
URL: https://github.com/apache/tvm/pull/7858#issuecomment-855007242


   @mbaret @leandron @u99127 @leo-arm the CI container has been updated, please take a look at this PR when you have a chance!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tristan-arm commented on pull request #7858: [ETHOSN] Removed support for 20.08 version of the driver stack.

Posted by GitBox <gi...@apache.org>.
tristan-arm commented on pull request #7858:
URL: https://github.com/apache/tvm/pull/7858#issuecomment-823908805


   cc @leandron @Leo-arm @u99127


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org