[GitHub] [spark] aokolnychyi commented on a diff in pull request #40919: [SPARK-43204][SQL] Align MERGE assignments with table attributes

["aokolnychyi (via GitHub)" <gi...@apache.org>]

aokolnychyi commented on code in PR #40919:
URL: https://github.com/apache/spark/pull/40919#discussion_r1174635165


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -1818,7 +1818,10 @@ class Analyzer(override val catalogManager: CatalogManager) extends RuleExecutor
             "sqlExpr" -> a.sql,
             "cols" -> cols))
       }
-      resolved
+      resolved match {

Review Comment:
   Without this change, nested references in MERGE are resolved as `t.struct_col.id AS id`, which breaks our assumption about what kind of keys we expect in assignments. It seems safe for both keys and values but let me know if there are any cases when it is not safe.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org