You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "ktf (via GitHub)" <gi...@apache.org> on 2023/02/10 09:17:20 UTC

[GitHub] [arrow] ktf opened a new pull request, #34116: Introduce ability to cast from int8 to float32 and int32

ktf opened a new pull request, #34116:
URL: https://github.com/apache/arrow/pull/34116

   ### Rationale for this change
   
   In our analysis, we need to be able to extend data from int8 to float32 and int32.
   
   ### What changes are included in this PR?
   
   Ability to cast int8 to float32 and int32 in Gandiva expressions.
   
   ### Are these changes tested?
   
   Yes. We run our analysis using them and they produce the expected result.
   
   ### Are there any user-facing changes?
   
   Nothing apart the newly introduced capabilities.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] cpcloud closed pull request #34116: GH-34117: [C++][Gandiva] Introduce ability to cast from int8 to float32 and int32

Posted by "cpcloud (via GitHub)" <gi...@apache.org>.
cpcloud closed pull request #34116: GH-34117: [C++][Gandiva] Introduce ability to cast from int8 to float32 and int32
URL: https://github.com/apache/arrow/pull/34116


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ktf commented on pull request #34116: GH-34117: [C++][Gandiva] Introduce ability to cast from int8 to float32 and int32

Posted by "ktf (via GitHub)" <gi...@apache.org>.
ktf commented on PR #34116:
URL: https://github.com/apache/arrow/pull/34116#issuecomment-1426311442

   Where are the tests for the current casting operators?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #34116: GH-34117: [C++ - Gandiva] Introduce ability to cast from int8 to float32 and int32

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34116:
URL: https://github.com/apache/arrow/pull/34116#issuecomment-1425490190

   :warning: GitHub issue #34117 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] cpcloud commented on pull request #34116: GH-34117: [C++][Gandiva] Introduce ability to cast from int8 to float32 and int32

Posted by "cpcloud (via GitHub)" <gi...@apache.org>.
cpcloud commented on PR #34116:
URL: https://github.com/apache/arrow/pull/34116#issuecomment-1490552991

   Thanks for the PR! Given the lack of activity I'm going to close it as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #34116: Introduce ability to cast from int8 to float32 and int32

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34116:
URL: https://github.com/apache/arrow/pull/34116#issuecomment-1425473619

   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
   
   Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename the pull request title in the following format?
   
       GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   In the case of PARQUET issues on JIRA the title also supports:
   
       PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #34116: GH-34117: [C++ - Gandiva] Introduce ability to cast from int8 to float32 and int32

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34116:
URL: https://github.com/apache/arrow/pull/34116#issuecomment-1425490116

   * Closes: #34117


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou commented on pull request #34116: GH-34117: [C++][Gandiva] Introduce ability to cast from int8 to float32 and int32

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34116:
URL: https://github.com/apache/arrow/pull/34116#issuecomment-1426366620

   https://github.com/apache/arrow/blob/master/cpp/src/gandiva/precompiled/arithmetic_ops_test.cc#L555-L593


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org