You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/12/08 16:31:07 UTC

[GitHub] [tvm] u99127 edited a comment on pull request #9682: [CMSIS-NN] Fixed return data type from pattern callback function

u99127 edited a comment on pull request #9682:
URL: https://github.com/apache/tvm/pull/9682#issuecomment-988971274


   We should be looking to add tests when they are fixing bugs at the time the commits go in to show what problem they are solving. Sometimes it is obvious but in this case we don't have any test coverage in the test suite for this failure. 
   
   A PR should also be ideally fixing one bug not multiple bugs and that too in an unclear fashion. 
   
   I'm not a committer or a reviewer in the TVM community , so others might have a different view.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org