[GitHub] [solr] gerlowskija commented on a change in pull request #577: SOLR-15745: Convert remaining 'core-admin' v2 APIs to annotations

[GitBox <gi...@apache.org>]

gerlowskija commented on a change in pull request #577:
URL: https://github.com/apache/solr/pull/577#discussion_r810479543



##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/request/beans/PrepareCoreRecoveryPayload.java
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.solr.client.solrj.request.beans;
+
+import org.apache.solr.common.annotation.JsonProperty;
+import org.apache.solr.common.util.ReflectMapWriter;
+
+public class PrepareCoreRecoveryPayload implements ReflectMapWriter {
+    @JsonProperty
+    public String nodeName;

Review comment:
       I suspect so, but I'm not certain enough to mark it that way here.
   
   The apispec file doesn't explicitly say it's required:
   
   ```
       "prep-recovery": {
         "type": "object",
         "additionalProperties": true,
         "description": "An internal API used by the Collections API. This should not be used directly by end-users."
       },
   ```
   
   And there's no null-checking or other sanity check in PrepRecoveryOp where this value is actually used that'd give me any confidence.
   
   Anyway, to avoid being overly restrictive, I left it as it was documented in the apispec for now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org