[GitHub] [helix] jiajunwang commented on a change in pull request #486: Integrate statistical measurement in the final OptimalAssignment output

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #486: Integrate statistical measurement in the final OptimalAssignment output
URL: https://github.com/apache/helix/pull/486#discussion_r325992797
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java
 ##########
 @@ -222,6 +222,12 @@ public int getAssignedReplicaCount() {
     return _currentCapacityMap;
   }
 
+
+  //TODO: will implement by merging other changes
+  public Map<String, Integer> getCapacityUsage() {
 
 Review comment:
   Let's don't make it public since it is not supporting the feature.
   I would prefer the model class to be clean and no extra method, as long as it is possible.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org