Re: [PR] [SPARK-46179][SQL] Add CrossDbmsQueryTestSuites, which allows generating golden files with other DBMS, starting off with Postgres [spark]

["andylam-db (via GitHub)" <gi...@apache.org>]

andylam-db commented on PR #44084:
URL: https://github.com/apache/spark/pull/44084#issuecomment-1866762533

   @jchen5 @agubichev @dtenedor Pinging for re-reviews :-) There's are quite a lot of changes since last time (read PR description).
   1. I changed `CrossDbmsQueryTestSuite` to be an abstract class, and then `PostgreSQLQueryTestSuite` to extend that.
   2. For `PostgreSQLQueryTestSuite`, the default input directory is `sql-tests/subquery`, to reduce the scope. In this PR, all files except for `exists-having.sql` are ignored, otherwise this PR would have 10K+ line changes, because I have to change the view creation syntax in these files a bit to be compatible with Postgres.
   3. I added a docker file and bash script for easy installation and start of a Postgres container.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org