[GitHub] [ignite-3] isapego commented on a diff in pull request #2149: IGNITE-19204 Implement ODBC connection establishment

["isapego (via GitHub)" <gi...@apache.org>]

isapego commented on code in PR #2149:
URL: https://github.com/apache/ignite-3/pull/2149#discussion_r1219625436


##########
modules/platforms/cpp/ignite/client/ignite_client_configuration.h:
##########
@@ -77,6 +85,26 @@ class ignite_client_configuration {
         ignite_client_configuration::m_endpoints.assign(endpoints.begin(), endpoints.end());
     }
 
+    /**
+     * Set endpoints.
+     *
+     * Examples of supported formats:
+     * - 192.168.1.25 - Default port is used, see DEFAULT_PORT;
+     * - 192.168.1.25:780 - Custom port;
+     * - 192.168.1.25:780..787  - Custom port range - ports are checked from

Review Comment:
   I'll do that for ODBC, but I'd prefer to do it in a separate ticket for client. I remove port ranges from the comments though.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org