You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/05/17 23:48:19 UTC

[GitHub] [incubator-mxnet] eric-haibin-lin commented on a change in pull request #14935: [OP] Accelerate GPU version of LayerNorm(axis=-1)

eric-haibin-lin commented on a change in pull request #14935: [OP] Accelerate GPU version of LayerNorm(axis=-1)
URL: https://github.com/apache/incubator-mxnet/pull/14935#discussion_r285317074
 
 

 ##########
 File path: src/operator/nn/layer_norm.cu
 ##########
 @@ -24,9 +24,662 @@
 */
 #include "./layer_norm-inl.h"
 
+using namespace mshadow::cuda;
+
 namespace mxnet {
 namespace op {
 
+template <typename DType>
+__device__ __forceinline__ DType WARP_SHFL(DType value, int src_lane,
 
 Review comment:
   Why is it capitalized? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services